Allowing gazebo_world_file arg to be passed in #148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-palmer
requested changes
Jan 11, 2024
This is done. |
evan-palmer
previously approved these changes
Jan 12, 2024
evan-palmer
approved these changes
Jan 13, 2024
|
Thanks for submitting this @timmarkhuff I will get it backported to Iron and Humble |
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2024
* Allowing gazebo_world_file arg to be passed in * updating gazebo_world_file arg in launch file * updating gazebo_world_file arg in launch file * Pre-commit --------- Co-authored-by: Evan Palmer <evanp922@gmail.com> (cherry picked from commit 01b385d)
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2024
* Allowing gazebo_world_file arg to be passed in * updating gazebo_world_file arg in launch file * updating gazebo_world_file arg in launch file * Pre-commit --------- Co-authored-by: Evan Palmer <evanp922@gmail.com> (cherry picked from commit 01b385d)
This was referenced Jan 13, 2024
evan-palmer
pushed a commit
that referenced
this pull request
Jan 14, 2024
* Allowing gazebo_world_file arg to be passed in * updating gazebo_world_file arg in launch file * updating gazebo_world_file arg in launch file * Pre-commit --------- Co-authored-by: Evan Palmer <evanp922@gmail.com> (cherry picked from commit 01b385d) Co-authored-by: Tim Huff <89954856+timmarkhuff@users.noreply.github.com>
evan-palmer
pushed a commit
that referenced
this pull request
Jan 14, 2024
* Allowing gazebo_world_file arg to be passed in * updating gazebo_world_file arg in launch file * updating gazebo_world_file arg in launch file * Pre-commit --------- Co-authored-by: Evan Palmer <evanp922@gmail.com> (cherry picked from commit 01b385d) Co-authored-by: Tim Huff <89954856+timmarkhuff@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when running
ros2 launch blue_bringup bluerov2.launch.py, thegazebo_world_fileargument is not supported.This PR allows users to pass in the argument. If no argument is provided,
bluerov2_underwater.worldwill be used.