Ignore invalid ICE candidates

This resolves an issue with Firefox.

Author: roehling

webrtc_ros/src/ice_candidate_message.cpp

@@ -1,4 +1,5 @@
 #include "webrtc_ros/ice_candidate_message.h"
+#include <ros/console.h>
 
 namespace webrtc_ros
 {
@@ -37,7 +38,10 @@ bool IceCandidateMessage::fromIceCandidate(const webrtc::IceCandidateInterface&
 
 webrtc::IceCandidateInterface* IceCandidateMessage::createIceCandidate()
 {
-  return webrtc::CreateIceCandidate(sdp_mid, sdp_mline_index, candidate, 0);
+  webrtc::SdpParseError err;
+  webrtc::IceCandidateInterface* result = webrtc::CreateIceCandidate(sdp_mid, sdp_mline_index, candidate, &err);
+  if (!result) ROS_WARN("SDP Parse Error: %s", err.description.c_str());
+  return result;
 }
 
 std::string IceCandidateMessage::toJson()

webrtc_ros/src/webrtc_client.cpp

@@ -226,7 +226,6 @@ void WebrtcClient::handle_message(MessageHandler::Type type, const std::string&
       if (!message.fromJson(message_json))
       {
         ROS_WARN("Can't parse received configure message.");
-        invalidate();
         return;
       }
 
@@ -372,15 +371,13 @@ void WebrtcClient::handle_message(MessageHandler::Type type, const std::string&
       if (!message.fromJson(message_json))
       {
         ROS_WARN("Can't parse received session description message.");
-        invalidate();
         return;
       }
 
       webrtc::SessionDescriptionInterface* session_description(message.createSessionDescription());
       if (!session_description)
       {
         ROS_WARN("Can't create session description");
-        invalidate();
         return;
       }
 
@@ -393,21 +390,18 @@ void WebrtcClient::handle_message(MessageHandler::Type type, const std::string&
       if (!message.fromJson(message_json))
       {
         ROS_WARN("Can't parse received ice candidate message.");
-        invalidate();
         return;
       }
 
       std::unique_ptr<webrtc::IceCandidateInterface> candidate(message.createIceCandidate());
       if (!candidate.get())
       {
         ROS_WARN("Can't parse received candidate message.");
-        invalidate();
         return;
       }
       if (!peer_connection_->AddIceCandidate(candidate.get()))
       {
         ROS_WARN("Failed to apply the received candidate");
-        invalidate();
         return;
       }
       ROS_DEBUG_STREAM("Received remote candidate :" << message.toJson());