Merge current master and fix file handling #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alRobots#267) I've had this lying around when implementing things. Maybe that would be useful to have it in the general library.
This should reduce the limit check getting triggered and also improve the check's output for debugging purposes.
… script_command servers (UniversalRobots#271) Before, we were sending the script code for execution to the robot and then opening the sockets that the script would connect to. This has been working fine in most cases, but that fails when too much time passes between the two steps. E.g. I experienced that when having debug output switched on, the robot script was not able to connect to the sockets. From my understanding this has been overlooked and there is no specific reason why the order was like that. Opening the sockets first and then sending the script seems to make more sense.
As `ctest` runs each test individually, an error with test initialization introduced earlier didn't show. This change makes sure that running all tests consecutively with initializing the test suite only once works correctly.
vdm-dev
approved these changes
Feb 25, 2025
vdm-dev
merged commit 8b3104d
into
RoboDK:feature/RDK-4115/windows-port
6 of 15 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file handling in the UrDriver tests was not working correctly.