You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix test runtime regression due to loadstring fallback check (#455)
## Problem
seeing a ~10% slowdown in large test suites, likely due to the
loadModuleEnabled check that runs once per file and does a ton of pcalls
and instance creation
```
- SocialCommon .................. succeeded (4.79 min)
- SocialCommon-fastFlags-allOn .. succeeded (4.88 min)
Total time: 4.88 min
```
```
- SocialCommon .................. succeeded (4.56 min)
- SocialCommon-fastFlags-allOn .. succeeded (4.59 min)
Total time: 4.59 min
```
## Solution
turn it into a const
## Testing
loadstring fallback should work as usual and pass the low privilege test
suite, seeing an improvement in test runtime in lua-apps
## Checklist
### For all changes
- [ ] Describe this change in `CHANGELOG.md`
- [ ] [Open a PR to add/update relevant examples in
jest-demo](https://github.com/Roblox/jest-demo)
### When working with upstream code (remove if not applicable)
- [ ] Newly translated modules have a `README.md` file with notes about
the translation
- [ ] All deviations are notated in code with `-- ROBLOX deviation:
comment`
- [ ] Translated files include a comment with a link to the upstream
file
Copy file name to clipboardExpand all lines: CHANGELOG.md
+1Lines changed: 1 addition & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -4,6 +4,7 @@
4
4
5
5
*:hammer_and_wrench: Rojo + Luau LSP is the new default workflow for Jest
6
6
development ([#453](https://github.com/Roblox/jest-roblox-internal/pull/453))
7
+
*:bug: Fix test runtime regression due to loadstring fallback check ([#455](https://github.com/Roblox/jest-roblox-internal/pull/455))
7
8
8
9
## 3.13.2 (2025-05-07)
9
10
*:bug: Correctly pass in `path` property of `test` in the `onTestCaseResult` reporter hook ([#450](https://github.com/Roblox/jest-roblox-internal/pull/450))
0 commit comments