Add support for doctrine/cache:v2
#110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Doctrine (orm, dbal etc.) going to use PSR-6|PSR-16, so doctrine/cache drop own cache implementations which previously could be instantiated in CacheFactory according to config in "doctrine.cache.{$cacheType}". Now only 'class' key supported to either get as service from container or className to be instantiated.
2. ConfigurationFactory lost usage of cache by default, see "doctrine.configuration.{$entityManagerName}" keys:
- 'metadata_cache'
- 'query_cache'
- 'result_cache'
- 'hydration_cache'
because no 'array' implementation
3. Left 'array' and 'filesystem' caches in full-config.php as example how to migrate to symfony/cache
4. Remove unused $configuration argument from ConfigurationFactory::processCacheImplementation()
…ctory 1. doctrine/orm Configuration class and its parent from doctrine/dbal does not support null in cache setters 2. To avoid `if` in ConfigurationFactory create NullCache implementation of PSR-6 interface. Avoid Doctrine\Common\Cache\Psr6\CacheItem (create own NullCacheItem) because someday we can remove "doctrine/cache" dependency 3. No type-hinting in NullCache and item to be compatible with "psr/cache:^1.0.1"
Slamdunk
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #72 as I'm not able to push on that branch.