Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are removal of parent classes/interfaces to be considered BC breaks? #106

Closed
Nyholm opened this issue Sep 2, 2018 · 6 comments
Closed
Assignees
Milestone

Comments

@Nyholm
Copy link
Contributor

Nyholm commented Sep 2, 2018

class Request implements PSR7RequestInterface
{
  // ...
}

If my Request class stops implementing PSR7RequestInterface, isnt that a BC break that should be detected?

class Request
{
  // ...
}
@Ocramius
Copy link
Member

Ocramius commented Sep 2, 2018

Yes, that's a BC break: so is removing any ancestor, as type checking will fail in consumers.

@Ocramius
Copy link
Member

Ocramius commented Sep 2, 2018

And yes, it is not implemented, but can be done trivially - do you want to try it, or should I give it a shot?

@Nyholm
Copy link
Contributor Author

Nyholm commented Sep 2, 2018

Im happy if you do it and I'll send the next hour implementing this excellent tool on more open source libraries.

@Ocramius
Copy link
Member

Ocramius commented Sep 2, 2018

I'll start right away. Be aware that inclusion in CLI will require a new major. Will also start implementing @api and @internal filters 👍

@Nyholm
Copy link
Contributor Author

Nyholm commented Sep 2, 2018

Okey, great.

My CI implementation do not care of new major versions of this library. I think it is a good idea to blindly trust that this library does not make anything weird. So until Im proven wrong Im just doing this:

https://github.com/php-translation/extractor/pull/123/files

@Ocramius Ocramius changed the title BC break question Are removal of parent classes/interfaces to be considered BC breaks? Sep 2, 2018
@Ocramius Ocramius added this to the 3.0.0 milestone Sep 2, 2018
@Ocramius Ocramius self-assigned this Sep 2, 2018
@Ocramius
Copy link
Member

Ocramius commented Sep 2, 2018

Handled in #109

@Ocramius Ocramius closed this as completed Sep 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants