Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCTCompileExt "forceCompile" not working #7

Closed
GoogleCodeExporter opened this issue Mar 28, 2015 · 5 comments
Closed

PCTCompileExt "forceCompile" not working #7

GoogleCodeExporter opened this issue Mar 28, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

I noticed that PCTCompileExt wasn't always respecting the last-modified 
timestamps for ".cls" files. It seems to work just fine for PCTCompile.

I created an additional test-case for "PCTCompileExtTest" (see attached).

I'm using OpenEdge 10.2B0406 and PCT v0.17 (02/07/2011).

Original issue reported on code.google.com by ethan.sherrie on 2 Aug 2011 at 7:00

Attachments:

@GoogleCodeExporter
Copy link
Author

Reproduced, thanks for your test case.
It seems that the procedure checking if r-code is already present or not is not 
working correctly.

I'll fix that ASAP and update this bug when a nightly build will contain the 
fix.

Original comment by g.quer...@gmail.com on 3 Aug 2011 at 9:58

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Do you have a timeline for this issue?

Thanks.

Original comment by ethan.bl...@sage.com on 12 Oct 2011 at 5:22

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

ASAP, but my main problem is the "P"... Not before two or three weeks.

I you want to implement the fix, the cause I've found when reproducing the bug 
lies in pct/pctBgCompile.p, line 263 to 267. Compilation units passed from Java 
to OpenEdge store output dir without package name (because OE preprend package 
names for us), and pctBgCompile doesn't take that into account.

The ASSIGN RCodeName = SUBSTRING(...) line should have a specific case for 
classes, and be able to deduce package name. 

Original comment by g.quer...@gmail.com on 12 Oct 2011 at 8:47

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Could you try build #152 ? Not ready for production use, there may be unknown 
bugs in PCTCompileExt as I changed the way compilation units are passed to the 
OpenEdge process. Test cases are OK though.

Original comment by g.quer...@gmail.com on 31 Oct 2011 at 10:20

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Assuming it's verified

Original comment by g.quer...@gmail.com on 8 Mar 2013 at 8:38

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant