Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty MetaData Values #1039

Open
philipbaileynar opened this issue Oct 24, 2024 · 3 comments
Open

Empty MetaData Values #1039

philipbaileynar opened this issue Oct 24, 2024 · 3 comments
Assignees
Labels
🐛 bug Something isn't working pkg:hydro_context Hydrologic Context Python Package

Comments

@philipbaileynar
Copy link
Contributor

Hydro Context contains several metadata keys that have no values. Technically the spec allows for this, but it is currently breaking some of our systems such as WebViewer. @MattReimer is patching these, but it's a good idea to avoid keys with no values.

<Meta name="SourceUrl" ext="dataset" type="url"/>
<Meta name="DataProductVersion" ext="dataset"/>

@jtgilbert can you please fix Hydro Context and either provide values for all MetaData or remove the entries from the project.rs.xml?

Screenshot 2024-10-24 at 3 00 39 PM
@philipbaileynar philipbaileynar added 🐛 bug Something isn't working pkg:hydro_context Hydrologic Context Python Package labels Oct 24, 2024
@jtgilbert
Copy link
Contributor

@philipbaileynar, this isn't an easy fix....
the lyr_discriptions.json present in every tool has three elements associated with each layer: a description, a source url, and a product version. This was mainly to keep track of versions and sources for layers in RSContext. So, b/c the source url and version aren't relevant for most layers, they're left blank (empty quotes) in lyr_description.json. The augment metadata function then adds all this info, creating an empty tag if there's not info filled in.
Bottom line, almost every project in the exchange probably has some of these empty meta tags.

@philipbaileynar
Copy link
Contributor Author

OK, maybe that's fine. @MattReimer ?

@MattReimer
Copy link
Member

Empty metadata is semantically fine as long as it's intended

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working pkg:hydro_context Hydrologic Context Python Package
Projects
None yet
Development

No branches or pull requests

3 participants