-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple pictures show, left and right sliding display #68
base: master
Are you sure you want to change the base?
Conversation
Thanks for the PR 👍 |
is this support available now? How to use this feature? |
how can fetch this |
<img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}"> Like a document, just an array is passed in |
so is it possible to add ion-slide in imageViewer?. I mean its more like gallery where user cal slide images also and they can zoom? |
@Muneem |
How? Right now its only one image. I want to add ion-slide inside imageviewer |
You have to use my pull request |
start from specified image index when viewing multiple images
@jianminLee ok then how would i use that feature? there is no documentation of how to use that feauture |
See the author's document just fine, I just added a function, and this function only need you to the array, the above reply I have given the code |
@jianminLee do you have working example of this feature? |
There are examples in the author's document <img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}"> or this.imageView.create(event.srcElement, {fullResImage: imgArr}).present(); imgArr and post.imgSrc can be an array or a string |
@jianminLee i have provided array but its not showing me next images in slider. it is just opening that image where i am clicking |
Are you sure you're using my pull request? Please get the code here |
How to use this as npm package? I have used npm install git+ your repo. but its giving me unmet peerdependency error |
Posted an error message |
@Muneem |
@jianminLee i am using latest ionic configuration. All my things are latest. I think your branch is old so i have to downgrade few things to test this functionality |
I'm sorry, I did not look at the wrong message carefully. I run in ionic-angular 3.6.0, |
It applies to ionic-angular 3.6.0
@jianminLee i downgraded my version. now its installed. but still its opening one image only. i have supplied imageViewer to my array but it is not showing me other images. |
Synchronize with author version
I found issue. I am passing array of images. And you are using this as src. You are not breaking it or yo are not considering it as array of images |
I do not understand what you mean, can you put the complete code? |
This is request object |
one more thing can you please send me screenshot of what you have implemente? |
have you check request object?screenshot which i have posted? |
Post.imgSrc = ['http://xxxx.xxx/xxx.jpg','http://xxxx.xxx/xxx.jpg','http://xxxx.xxx/xxx.jpg','http: //xxxx.xxx/xxx.jpg ']; You can try to http://xxxx.xxx/xxx.jpg all replaced by a valid image url, look at the effect. Casually to google a few pictures of the url |
Then like this: <ion-thumbnail item-right *ngIf="post.imgSrc.length">
<img item-right src="{{post.imgSrc[0]}}" imageViewer="{{post.imgSrc}}">
</ion-thumbnail> |
@jianminLee can you please tell me how could i include this in ionic project? As through npm installl i am unable to include your branch in my ionic project |
npm install https://github.com/jianminLee/ionic-img-viewer.git This is not what? |
When i run npm install it foes not install from your branch
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: jianmingLee <notifications@github.com>
Sent: Thursday, August 17, 2017 6:03:39 PM
To: Riron/ionic-img-viewer
Cc: Muneem; Mention
Subject: Re: [Riron/ionic-img-viewer] Support multiple pictures show, left and right sliding display (#68)
@Muneem<https://github.com/muneem>
npm install https://github.com/jianminLee/ionic-img-viewer.git
This is not what?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGRcTP7U9XAsHHhaMaXWyr0omGqaE6x_ks5sZEg7gaJpZM4OJCGh>.
|
If not, then I have no good idea, you can download directly to use |
these all changes are present here: https://github.com/jianminLee/ionic-img-viewer |
? |
Yes I will merge all the changes to the author |
@jianminLee one suggestion put it in master and generate new npm version also. |
how can i get this branch?? im using ionic 3.9.2 |
added title and icons in header. @keephacking
Currently it won't install because @jianminLee has an invalid semver version in the package.json. Sent a PR for that. Hopefully it will be merged, and hopefully that will get merged here! |
+1, would be useful |
Fix installation from non-registry
This is THE feature. It would be the best plugin if this kind of support would be added. |
Hi, |
Hi, |
@Shals08 |
@jianminLee |
This worked for me
|
ionic4 angular7 This worked for me. |
sorry,my English is bad....
I have added more pictures to slide show。
It is necessary to explain here
Because of the animation, I have to do a lot of operations here, if you choose a picture of a, I need to show that the effect of animation, and then slide to show before or after the picture, I really no better The way.
Use the same as before, just can be passed to the array or a single image URL.
Thank you again, this project is very helpful for my work, the animation is very cool, of course, the hope of the code for your project also help。