Fix exponential backoff algorithm truncating exponential factor#14
Open
tinnywang wants to merge 1 commit intoRican7:masterfrom
Open
Fix exponential backoff algorithm truncating exponential factor#14tinnywang wants to merge 1 commit intoRican7:masterfrom
tinnywang wants to merge 1 commit intoRican7:masterfrom
Conversation
Owner
|
Oh wow, thanks for this Tiffany! Sorry that I'm just now getting to this. Now that I think about it... oof... there's a few different places where gross conversions between float and int are happening... I think I'm going to audit all of those and re-think some things before merging this so that the change can be more consistent throughout the codebase. Thanks for bringing this to my attention and for proposing these changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The exponential backoff algorithm truncates the exponential factor when
math.Pow(base, float64(attempt))is converted totime.Duration(the type conversion is fromfloat64toint64).This makes the delay between retries not increase exponentially when the base is a non-integer.
For example, the expected vs. actual results for the first five attempts of
Exponential(100 * time.Millisecond, 1.2)are shown below:To fix this, multiply the duration factor by the exponential factor before converting anything back to
time.Duration.