Release 1.2.0 #76
Merged
Release 1.2.0 #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aboedo bump |
|
@vegaro sorry I'd missed this! reviewing |
aboedo
approved these changes
Jul 1, 2020
| static PurchasesErrorCode getErrorCode(PlatformException e) { | ||
| return PurchasesErrorCode.values[int.parse(e.code)]; | ||
| var errorCode = int.parse(e.code); | ||
| if (errorCode >= PurchasesErrorCode.values.length) { |
There was a problem hiding this comment.
this is good, although it serves as a good reminder that we'll have to be more careful regarding keeping the codes in sync.
There was a problem hiding this comment.
Yes, I wonder if we could break the compilation somehow, or maybe add a test?
There was a problem hiding this comment.
I was actually thinking about that same thing for the swift enum in purchases-ios. a test might be the way to go, even if it only covers that the number of possible values is the same on both sides
lib/errors.dart
Outdated
Comment on lines
40
to
42
| /// if (errorCode == PurchasesErrorCode.purchaseCancelledError) { | ||
| /// print("User cancelled"); | ||
| /// } else if (errorCode == PurchasesErrorCode.purchaseNotAllowedError) { |
There was a problem hiding this comment.
nitpick: would a switch be more suitable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setProxyURL(bump native sdks #63)setFinishTransactions(Exposes finishTransactions to flutter code #45)