-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposes finishTransactions to flutter code #45
Conversation
Thanks for opening this @loregr I have one question though. Are you trying to set the SDK in observer mode? Why do you need to set finishTransactions? There's already a parameter in the setup call https://github.com/RevenueCat/purchases-flutter/blob/master/lib/purchases_flutter.dart#L34 that will let you set the SDK in observer mode in case you already have other iap system in place and you don't want our SDK to finish/consume any transaction. SetFinishTransactions is kinda the legacy way of setting the SDK in observer mode. |
@vegaro thanks for your feedback. In my understanding (and I may be wrong) observer mode is to be used when I want only to get access to the advanced charting, webhooks, and attribution while I manage purchases and restores in a native way (or without going through revenueCat SDK). |
I see, that makes sense. Can't you get that functionality by using the information inside (sorry it took so long to reply 🤦) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loregr
thanks so much for opening and for the feedback!
There are a couple of minor indentation issues that we should fix before merging, but we can take care of them if you don't have the time, just let us know.
Otherwise, this looks good to go.
Co-authored-by: aboedo <andresboedo@gmail.com>
Co-authored-by: aboedo <andresboedo@gmail.com>
I've implemented a method to be able to use
setFinishTransactions
from Dart.