Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove macos platform support in purchases_ui_flutter #1041

Merged
merged 1 commit into from
Apr 11, 2024
Merged

Conversation

vegaro
Copy link
Contributor

@vegaro vegaro commented Apr 11, 2024

#1038 reports that MacOS is not working properly. The PaywallView and PaywallFooterView are being wrapped with UIKit, but they need to use AppKit, which is what's available in MacOS.

This PR removes support for now until we figure out what we need to do

@vegaro vegaro added pr:fix A bug fix pr:force_minor Change should force a minor release labels Apr 11, 2024
@vegaro vegaro requested a review from a team April 11, 2024 12:10
@vegaro vegaro merged commit 5ef6dbd into main Apr 11, 2024
8 checks passed
@vegaro vegaro deleted the remove-macos branch April 11, 2024 15:49
tonidero pushed a commit that referenced this pull request Apr 18, 2024
**This is an automatic release.**

### Bugfixes
* Fix touches passing through paywall when using presentPaywall methods
(#1044) via Toni Rico (@tonidero)
* Remove macos platform support in purchases_ui_flutter (#1041) via
Cesar de la Vega (@vegaro)
### Dependency Updates
* [AUTOMATIC BUMP] Updates purchases-hybrid-common to 10.4.1 and adds
`externalStore` to `Store` enum (#1043) via RevenueCat Git Bot
(@RCGitBot)
* [Android
7.8.2](https://github.com/RevenueCat/purchases-android/releases/tag/7.8.2)
* [iOS
4.40.1](https://github.com/RevenueCat/purchases-ios/releases/tag/4.40.1)
@dsvf
Copy link

dsvf commented Jun 25, 2024

Hi there! True to xkcd 1172 (every change breaks someones workflow), this PR broke my workflow.

I develop and publish an iOS/Android app, but I do the flutter development as a Mac OS "native" app, since for regular coding and testing the workflow is smoother and less resource-intensive than using Simulator/an emulator. The paywall part of my app is long-since validated and shipped, and the Mac OS build never leaves my device - it is debug only. So that the purchase does not work on Mac OS is not important while I work on other features.

However, since this version, I can no longer even build a local debug build, since there is a dependency resolution problem - there is no latest purchases_ui version for Mac OS.

Now, I could theoretically remove RevCat for my debug builds and re-add them when building for release, but the previous way was perfect as-is. I have as of now pinned purchases-flutter to 6.26.0 to re-enable my Mac OS debug build situation, but if there was a way to secretly re-add this, that would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fix A bug fix pr:force_minor Change should force a minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants