Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomerInfo == / hashCode aren't working #935

Open
lukepighetti opened this issue Jan 15, 2024 · 3 comments
Open

CustomerInfo == / hashCode aren't working #935

lukepighetti opened this issue Jan 15, 2024 · 3 comments
Labels
bug Something isn't working status: needs-additional-info Issues that are missing steps from bug template

Comments

@lukepighetti
Copy link

This package is using freezed which creates an expectation of being able to use == / hashCode with the data models within. CustomerInfo? breaks this expectations, likely through use of the Unmodifiable collection views. These appear to be changing the order of the elements in the collection on each instantiation, thus breaking == / hashCode. That means we cannot rely on equality check to ensure that we aren't updating our UI when it's not needed.

@lukepighetti lukepighetti added the bug Something isn't working label Jan 15, 2024
@RCGitBot
Copy link
Contributor

👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out!

@NachoSoto
Copy link
Contributor

Hi thanks for the report!
Could you send us an example CustomerInfo that's reproducing this issue?

@NachoSoto NachoSoto added the status: needs-additional-info Issues that are missing steps from bug template label Jan 22, 2024
@lukepighetti
Copy link
Author

Not sure how I'm supposed to do that. It lives in memory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status: needs-additional-info Issues that are missing steps from bug template
Projects
None yet
Development

No branches or pull requests

3 participants