Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: don't add an Activity on top of the Flutter's MainActivity #324

Closed
rocboronat opened this issue Feb 15, 2022 · 7 comments
Closed
Labels
enhancement New feature or request status: needs-additional-info Issues that are missing steps from bug template

Comments

@rocboronat
Copy link

Without checking the code, I see you are doing something strange before showing the native purchase dialog. The same when you close the dialog.

If you really need to show it, make it totally unperceivable. If I can see something strange happen, users will too.

@rocboronat rocboronat added the enhancement New feature or request label Feb 15, 2022
@ghost ghost added the status: needs-additional-info Issues that are missing steps from bug template label Feb 15, 2022
@rocboronat
Copy link
Author

rocboronat commented Feb 15, 2022

This is how it looks on a Pixel 4a 👇
video

See the app resizes when opening the purchase dialog, and a black bar crosses the screen from top to bottom when closing it 😿

@RevenueCat RevenueCat deleted a comment Feb 15, 2022
@beylmk
Copy link
Contributor

beylmk commented Feb 15, 2022

Hey @rocboronat, agreed that this experience is a little weird...RevenueCat doesn't have any control over this, unfortunately. Google's BillingClient (which we rely on to make purchases) creates a transparent activity when launching the billing flow (see related cordova issue: ...you're not alone!)

As mentioned in that ticket, there is a workaround.

@beylmk
Copy link
Contributor

beylmk commented Feb 15, 2022

Going to close for now, let me know how this goes!

@beylmk beylmk closed this as completed Feb 15, 2022
@rocboronat
Copy link
Author

Thanks for the link, @beylmk ! Do you have any open issue with the billing team of Google? Just to add a star there and maybe add a bit of weight on it.

@rocboronat
Copy link
Author

I found a link: https://issuetracker.google.com/issues/153476408

Please, star it if you think it's important :·)

@beylmk
Copy link
Contributor

beylmk commented Feb 16, 2022

Thanks for finding that @rocboronat ... starred!

@armandojimenez
Copy link

Hey @rocboronat, agreed that this experience is a little weird...RevenueCat doesn't have any control over this, unfortunately. Google's BillingClient (which we rely on to make purchases) creates a transparent activity when launching the billing flow (see related cordova issue: ...you're not alone!)

As mentioned in that ticket, there is a workaround.

I tried this workaround in flutter but in my manifest this class is not found: android:name="com.android.billingclient.api.ProxyBillingActivity"

any help how to implement this workaround in Flutter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request status: needs-additional-info Issues that are missing steps from bug template
Projects
None yet
Development

No branches or pull requests

3 participants