-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paywall - Unable to set theme mode for native view #1142
Comments
👀 We've just linked this issue to our internal tracker and notified the team. Thank you for reporting, we're checking this out! |
Hi @csbence10 thanks for the feedback, I notified the engineering team and will let you know what they say |
Hello! It looks like you're switching light and dark mode independently of the system. Currently our paywalls follow the system dark mode setting with no way to change it manually. The team is aware of this now, currently it's not scheduled to be added in the near future but that may change later. |
Hey,
So I think it's a valid use-case and doesn't require too much resource from the team. It would be appreciated if someone could address this. Thanks, Bence |
Hi @csbence10, yes that's completely reasonable feedback, it's just a matter of us prioritizing it with other work and features we want to release |
This is also an issue when you change the locale independently of the system. You may have a Flutter app that is rendering all text in mandarin, but opening the paywall will be in english. |
Do not remove any of the steps from the template below. If a step is not applicable to your issue, please leave that step empty.
There are a lot of things that can contribute to things not working. Having a very basic understanding of your environment will help us understand your issue faster!
Environment
Output of
flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.24.0, on macOS 14.5 23F79 darwin-arm64, locale hu-HU)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 15.2)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2023.2)
[✓] VS Code (version 1.92.1)
[✓] Connected device (6 available)
[✓] Network resources
Version of
purchases-flutter
: 7.0.1Testing device version e.g.: iOS 17.2
How often the issue occurs- every one of your customers is impacted? Only in dev? Every time
Debug logs that reproduce the issue
Steps to reproduce, with a description of expected vs. actual behavior
themeMode
property ofMaterialApp
toThemeMode.light
ThemeMode.dark
Other information (e.g. stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, etc.)
PaywallView
andPaywallFooterView
(InternalPaywallFooterView
) should have a new property to determine the theme mode. This property should initialize the native view accordingly. We should pass this property throughcreationParams
. Additionally, a method handler should be set up to subscribe to theme changes and respond appropriately.Describe the bug
In our app, users can choose between automatic theme mode (adapting to system settings), or manually setting the theme to light or dark.
When the app theme is aligned with the system theme, the paywall displays correctly. However, when the system theme is dark and the app theme is set to light (or vice versa), the UI appears visually unappealing.
Additional context
The text was updated successfully, but these errors were encountered: