Skip to content

Commit fbf9a90

Browse files
committed
Nits
1 parent 6819f12 commit fbf9a90

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

hw/femu/femu.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,7 @@ static void nvme_init_ctrl(FemuCtrl *n)
407407
id->cmic = 0;
408408
id->mdts = n->mdts;
409409
id->ver = 0x00010300;
410+
/* TODO: NVME_OACS_NS_MGMT */
410411
id->oacs = cpu_to_le16(n->oacs | NVME_OACS_DBBUF);
411412
id->acl = n->acl;
412413
id->aerl = n->aerl;
@@ -474,7 +475,8 @@ static void nvme_init_cmb(FemuCtrl *n)
474475
NVME_CMBSZ_GETSIZE(n->bar.cmbsz));
475476
pci_register_bar(&n->parent_obj, NVME_CMBLOC_BIR(n->bar.cmbloc),
476477
PCI_BASE_ADDRESS_SPACE_MEMORY |
477-
PCI_BASE_ADDRESS_MEM_TYPE_64, &n->ctrl_mem); }
478+
PCI_BASE_ADDRESS_MEM_TYPE_64, &n->ctrl_mem);
479+
}
478480

479481
static void nvme_init_pci(FemuCtrl *n)
480482
{
@@ -522,6 +524,7 @@ static int nvme_register_extensions(FemuCtrl *n)
522524
} else if (ZNSSD(n)) {
523525
nvme_register_znssd(n);
524526
} else {
527+
/* TODO: For future extensions */
525528
}
526529

527530
return 0;

hw/femu/nvme.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,7 +755,7 @@ enum NvmeIdCtrlOacs {
755755
NVME_OACS_SECURITY = 1 << 0,
756756
NVME_OACS_FORMAT = 1 << 1,
757757
NVME_OACS_FW = 1 << 2,
758-
NVME_OACS_Oc12DEV = 1 << 3,
758+
NVME_OACS_Oc12DEV = 1 << 3,
759759
NVME_OACS_DBBUF = 1 << 8,
760760
};
761761

0 commit comments

Comments
 (0)