Regex may potential match all traffic #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghjansen
reviewed
Nov 23, 2017
| * @return the longest regex matching any number in the list, null if no match | ||
| */ | ||
| private IncomingPhoneNumber findByRegex(List<String> numberQueries, | ||
| Sid sourceOrganizationSid, Sid destOrg) { |
There was a problem hiding this comment.
Parameter sourceOrganizationSid not used in the scope.
There was a problem hiding this comment.
agree, we may remove this, let me quickly fix that
|
@ghjansen i have merged this with categories branch and the result oftesting is https://cxs.restcomm.com/view/Restcomm/job/Restcom-CI-Multibranch/job/issue1233_agg_annos/lastCompletedBuild/testReport/ -> 17 fails im checking locally whether these are broken or just unstable |
|
testsuite is finally positive after latest changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.