Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue2608 numbers filterd by app sid #2630

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

otsakir
Copy link
Contributor

@otsakir otsakir commented Nov 10, 2017

Added application-based filtering to IncomingPhoneNumber list method.The patch includes:

  • Small change in REST layer so that ApplicationSid parameter is recognized
  • Inclusion of applicationSid in IncomingPhoneNumber filter
  • Changes in mybatis descriptors. All related .xml files have been updated including mariadb and tetsts.
  • Automated tests
  • Updates in the docs

Also, a binary has been produced locally and tested manually for the new feature. Both hsql and mariadb backends were used.

This relates to #2608

…t test and mybatis layer update (for test only)

Refers #2608
… the codebase (tests, mysql descriptors etc.)

Refers #2608
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants