Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error message for closed accounts login in Console #2777

Open
otsakir opened this issue Jan 25, 2018 · 5 comments · May be fixed by #2889
Open

Error message for closed accounts login in Console #2777

otsakir opened this issue Jan 25, 2018 · 5 comments · May be fixed by #2889

Comments

@otsakir
Copy link
Contributor

otsakir commented Jan 25, 2018

When trying to sign in a closed account, Console displays an "Error. Unknown error" message. Insead, we should display something like: "Sorry, you can't use this account. It has been closed".

@ddhuy
Copy link

ddhuy commented Mar 19, 2018

hi @otsakir , I would like to contribute a fix for this ticket. Would you mind if I change the warning message to "Sorry! The account was closed." or can you please specify the warning message you want me to change to.

@otsakir
Copy link
Contributor Author

otsakir commented Mar 21, 2018

Hi @ddhuy . Well, i would still go with the first option. i.e. "Sorry, you can't use this account. It has been closed".

Thanks for offering! 👍

@ddhuy
Copy link

ddhuy commented Mar 23, 2018

Hi @otsakir Thank you. I have tried to reproduce the issue you have but seems that the notification message is different (please check the attached images). I checked the code and observed that "Error! Unknown error" is a general error message rather than closed account reason. I roughly guest that it can be another issue you met at that time or am I miss something.

At RC console this is shows that "Error! Login Failed. Please confirm your username and password"
rc-console-closed-account-notification

At HTTP response it shows that "Provided account is not active"
rc-console-closed-account-response

Is your intend to make difference between wrong authentication & bad permission?

@otsakir
Copy link
Contributor Author

otsakir commented Mar 23, 2018

Oops! @ddhuy it looks like the issue is a little outdated. I would say that if the status is different (403 instead of 401 in case of just bad credentials) user deserves a different warning message.

@ddhuy ddhuy linked a pull request Mar 28, 2018 that will close this issue
@ddhuy
Copy link

ddhuy commented Mar 28, 2018

Hi @otsakir , I have just put a PR#2889 for this issue. Please have a check and let me know your opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants