Fixes per CodeRabbit comments

Author: MantisClone

packages/create-invoice-form/src/lib/create-invoice-form.svelte

@@ -77,7 +77,7 @@
   let defaultCurrencies = currencyManager.knownCurrencies.filter(
     (currency: CurrencyTypes.CurrencyDefinition) =>
       currency.type === Types.RequestLogic.CURRENCY.ISO4217 ||
-      (network ? currency.network === network : true)
+      network ? currency.network === network : true
   );
 
   const handleInvoiceCurrencyChange = (

packages/create-invoice-form/src/lib/utils/prepareRequest.ts

@@ -118,11 +118,12 @@ export const prepareRequestParams = ({
           invoiceCurrency.decimals
         ).toString(),
         discount:
-          item.discount != null &&
-            parseUnits(
+          item.discount != null
+            ? parseUnits(
               item.discount.toString(),
               invoiceCurrency.decimals
-            ).toString(),
+            ).toString()
+            : undefined,
         tax: {
           type: "percentage",
           amount: item.tax.amount.toString(),

packages/invoice-dashboard/src/lib/dashboard/invoice-view.svelte

@@ -248,7 +248,7 @@
 
     return (
       (paymentNetworkExtension?.id &&
-        approvalCheckers[paymentNetworkExtension.id]?.()) ||
+        await approvalCheckers[paymentNetworkExtension.id]?.()) ||
       false
     );
   };

shared/utils/generateInvoice.ts

@@ -108,9 +108,9 @@ export const exportToPDF = async (
       </div>
 
       <div style="margin-bottom: 20px; font-size: 10px;">
-        <strong>Payment Chain:</strong> ${paymentCurrencies && paymentCurrencies[0] && paymentCurrencies[0].network ? paymentCurrencies[0].network : "-"}<br>
+        <strong>Payment Chain:</strong> ${paymentCurrencies?.[0]?.network ?? "-"}<br>
         <strong>Invoice Currency:</strong> ${invoice.currency || "-"}<br>
-        <strong>Settlement Currency:</strong> ${paymentCurrencies && paymentCurrencies[0] && paymentCurrencies[0].symbol ? paymentCurrencies[0].symbol : "-"}<br>
+        <strong>Settlement Currency:</strong> ${paymentCurrencies?.[0]?.symbol ?? "-"}<br>
       </div>
 
       <table>