-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(data-access): thegraph-data-access package #931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjlevesque
changed the base branch from
master
to
refactor/payment-network-factory
October 5, 2022 17:19
benjlevesque
changed the title
refactor/storage/the graph data access
refactor(storage): the graph data access
Oct 5, 2022
github-actions
bot
requested review from
alexandre-abrioux,
bertux,
leoslr and
yomarion
October 5, 2022 18:41
benjlevesque
changed the title
refactor(storage): the graph data access
refactor(data-access): thegraph-data-access package
Oct 5, 2022
yomarion
approved these changes
Oct 6, 2022
} | ||
|
||
/** Interface of the storage */ | ||
export interface IStorage extends IStorageRead, IStorageWrite { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💅
bertux
approved these changes
Oct 6, 2022
benjlevesque
force-pushed
the
refactor/payment-network-factory
branch
from
October 6, 2022 15:23
772e5de
to
fd82335
Compare
benjlevesque
force-pushed
the
refactor/storage/the-graph-data-access
branch
from
October 6, 2022 15:24
ec51d27
to
30896bc
Compare
benjlevesque
force-pushed
the
refactor/storage/the-graph-data-access
branch
from
October 6, 2022 17:26
30896bc
to
5886f41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 😀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduce a new package to easily re-use thegraph data access.
Move non-graph logic to their relevant places
Usage
Full
Read only