Skip to content

Conversation

@alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Mar 10, 2025

Description of the changes

Fixup for #1577
The distribution tag should always be next; I made a mistake updating that option.

See here the wrong tag created in the last commit (removed manually from NPM since)

image

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2025

Walkthrough

This pull request updates the package publishing scripts in the package.json file. Both the publish-manual-prerelease and publish-prerelease scripts have been modified to use a static --dist-tag value of next instead of appending the Git commit short hash. These changes standardize the prerelease process for packages managed by Lerna.

Changes

File Change Summary
package.json Updated the scripts "publish-manual-prerelease" and "publish-prerelease" by replacing the dynamic --dist-tag value combining next and the Git commit hash with a static next value.

Possibly related PRs

  • ci: fix next-release #1576: Involves similar modifications to the publishing scripts in package.json, focusing on changes to the prerelease process.
  • fix: prerelease command #1532: Addresses analogous simplifications in the package publishing commands within package.json.
  • fix: prerelease git issue #1535: Incorporates changes to the lerna publish command options that align with the current update, particularly concerning the handling of version tagging.

Suggested reviewers

  • rodrigopavezi
  • kevindavee
  • sstefdev
  • leoslr
  • MantisClone

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a312eb9 and 3f08207.

📒 Files selected for processing (1)
  • package.json (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-and-test
🔇 Additional comments (2)
package.json (2)

28-28: Update "publish-manual-prerelease" Script to Use a Static Distribution Tag

The --dist-tag option is now set to "next" instead of including the Git commit short hash, which ensures a consistent prerelease tag across manual publishes. Please confirm that keeping the dynamic value for --preid (i.e. next.$(git rev-parse --short HEAD)) is still intentional in your workflow.


29-29: Update "publish-prerelease" Script to Standardize the Distribution Tag

Similar to the manual script, the --dist-tag in the "publish-prerelease" command has been updated to the static value "next". This change standardizes the distribution tag for prereleases. Ensure that this update does not interfere with any automated release processes that might expect a dynamic tag.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@alexandre-abrioux alexandre-abrioux enabled auto-merge (squash) March 10, 2025 17:48
Copy link
Member

@rodrigopavezi rodrigopavezi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@alexandre-abrioux alexandre-abrioux merged commit ac63e08 into master Mar 10, 2025
11 checks passed
@alexandre-abrioux alexandre-abrioux deleted the ci-fix-dist-tag branch March 10, 2025 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants