Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: xdai eth conversion #1451

Merged
merged 1 commit into from
Sep 11, 2024
Merged

feat: xdai eth conversion #1451

merged 1 commit into from
Sep 11, 2024

Conversation

leoslr
Copy link
Contributor

@leoslr leoslr commented Sep 10, 2024

Description of the changes

Additional deployment on xDai (GnosisChain):

  • Deployment of the latest version of ChainlinkConversionPath. The previous version deployed wasn't able to support EthConversionProxy
  • Deployment of the EthConversionProxy contract.

✅ Contracts verified
✅ The new ChainlinkConversionPath has been fed the list of aggregators set in the previous version.
✅ Ownership transferred to the RN Admin contract

Next steps:

  • Subgraph update
  • Update the values of chainlinkConversionPath and ethConversionProxy in the Batch contract on xDai

Summary by CodeRabbit

  • New Features
    • Updated xdai network configuration for the Chainlink conversion path, ensuring accurate contract details.
    • Added support for the xdai network in the EthConversionProxy, enhancing multi-network functionality.

Copy link

coderabbitai bot commented Sep 10, 2024

Walkthrough

The pull request introduces updates to the ChainlinkConversionPath and EthConversionProxy modules. It modifies the xdai network configuration in the chainlinkConversionPath constant by changing the contract address and creation block number. Additionally, a new entry for the xdai network is added to the ethConversionArtifact constant, enabling support for this network in version 0.2.1. These changes ensure that both modules reflect the most current contract details and expand their compatibility with the xdai network.

Changes

File Path Change Summary
packages/smart-contracts/src/lib/artifacts/ChainlinkConversionPath/index.ts Updated xdai network configuration: changed address and creation block number.
packages/smart-contracts/src/lib/artifacts/EthConversionProxy/index.ts Added new xdai entry to ethConversionArtifact for version 0.2.1, including address and creation block number.

Tip

Announcements
  • The review status is no longer posted as a separate comment when there are no actionable or nitpick comments. In such cases, the review status is included in the walkthrough comment.
  • We have updated our review workflow to use the Anthropic's Claude family of models. Please share any feedback in the discussion post on our Discord.
  • Possibly related PRs: Walkthrough comment now includes a list of potentially related PRs to help you recall past context. Please share any feedback in the discussion post on our Discord.
  • Suggested labels: CodeRabbit can now suggest labels by learning from your past PRs in the walkthrough comment. You can also provide custom labeling instructions in the UI or configuration file.
  • Possibly related PRs, automatic label suggestions based on past PRs, learnings, and possibly related issues require data opt-in (enabled by default).

Recent review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 2b39290 and 5e8e575.

Files selected for processing (2)
  • packages/smart-contracts/src/lib/artifacts/ChainlinkConversionPath/index.ts (1 hunks)
  • packages/smart-contracts/src/lib/artifacts/EthConversionProxy/index.ts (2 hunks)
Additional comments not posted (3)
packages/smart-contracts/src/lib/artifacts/EthConversionProxy/index.ts (2)

107-110: LGTM!

The addition of the xdai network entry in the ethConversionArtifact constant for version 0.2.0 is approved. This change enables support for deploying or interacting with the EthConversionProxy contract on the xdai network, expanding its compatibility and usability.


125-128: LGTM!

The addition of the xdai network entry in the ethConversionArtifact constant for version 0.2.1 is approved. This change enables support for deploying or interacting with the EthConversionProxy contract on the xdai network, expanding its compatibility and usability.

packages/smart-contracts/src/lib/artifacts/ChainlinkConversionPath/index.ts (1)

93-94: LGTM, but verify the contract usage.

The update to the xdai network configuration in the chainlinkConversionPath constant is approved.

However, ensure that this change is thoroughly tested to confirm that it behaves as expected and that all interactions with the ChainlinkConversionPath contract on the xdai network have been updated to use the new address.

Run the following script to verify the contract usage:


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MantisClone
Copy link
Member

Thanks @leoslr
I created an issue to update the docs. I'll have someone on the RN team handle it.
RequestNetwork/docs.request.network#60

@leoslr leoslr merged commit badef50 into master Sep 11, 2024
26 checks passed
@leoslr leoslr deleted the feat/xdai-eth-conversion branch September 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants