-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: payments subgraph Alchemy URLs: ZkSync Era, Avalanche, and Fantom #1449
chore: payments subgraph Alchemy URLs: ZkSync Era, Avalanche, and Fantom #1449
Conversation
WalkthroughThe changes to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- packages/payment-detection/src/thegraph/client.ts (1 hunks)
Additional comments not posted (1)
packages/payment-detection/src/thegraph/client.ts (1)
116-119
: Approve addition of new networks but verify URL formation.The changes to include 'zksyncera', 'avalanche', and 'fantom' in the
defaultGetTheGraphClient
function follow the established pattern and are correctly implemented. However, ensure that the URLs formed with these network names are valid and accessible.Run the following script to verify the URL formation:
Verification successful
URLs for new networks are correctly formed and accessible.
The URLs for the networks 'zksyncera', 'avalanche', and 'fantom' are correctly formed and accessible, as confirmed by the HTTP 200 responses. This verifies that the changes to the
defaultGetTheGraphClient
function are correctly implemented. No further action is needed.Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the URL formation for the new networks. # Test: Check if the URLs for the new networks are correctly formed and accessible. for network in zksyncera avalanche fantom; do echo "Testing URL for $network:" curl -I "${THE_GRAPH_ALCHEMY_URL.replace('$NETWORK', network)}" doneLength of output: 226
Script:
#!/bin/bash # Description: Verify the URL formation for the new networks using correct bash syntax. # Check if THE_GRAPH_ALCHEMY_URL is set if [ -z "${THE_GRAPH_ALCHEMY_URL}" ]; then echo "THE_GRAPH_ALCHEMY_URL is not set." exit 1 fi # Test: Check if the URLs for the new networks are correctly formed and accessible. for network in zksyncera avalanche fantom; do url="${THE_GRAPH_ALCHEMY_URL/\$NETWORK/$network}" echo "Testing URL for $network: $url" curl -I "$url" doneLength of output: 101
Script:
#!/bin/bash # Description: Search for the definition or initialization of THE_GRAPH_ALCHEMY_URL in the codebase. # Search for THE_GRAPH_ALCHEMY_URL in the codebase rg 'THE_GRAPH_ALCHEMY_URL' --context 5Length of output: 1792
Script:
#!/bin/bash # Description: Verify the URL formation for the new networks using the constant from the codebase. # Define the constant as per the codebase THE_GRAPH_ALCHEMY_URL='https://subgraph.satsuma-prod.com/e2e4905ab7c8/request-network--434873/request-payments-$NETWORK/api' # Test: Check if the URLs for the new networks are correctly formed and accessible. for network in zksyncera avalanche fantom; do url="${THE_GRAPH_ALCHEMY_URL/\$NETWORK/$network}" echo "Testing URL for $network: $url" curl -I "$url" doneLength of output: 4085
…s-subgraph-alchemy-urls
…s-subgraph-alchemy-urls
Description of the changes
Summary by CodeRabbit