-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps-dev): Bump webpack from 5.88.2 to 5.94.0 #1446
Conversation
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the WalkthroughThe changes involve updating the Changes
TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
Files selected for processing (4)
- packages/epk-decryption/package.json (1 hunks)
- packages/epk-signature/package.json (1 hunks)
- packages/request-client.js/package.json (1 hunks)
- packages/web3-signature/package.json (1 hunks)
Additional comments not posted (4)
packages/web3-signature/package.json (1)
64-64
: Approved: Webpack version update.The update from
5.88.2
to5.94.0
in thewebpack
dependency is aligned with the PR objectives. This should bring in the improvements and bug fixes as noted in the release notes.Run the following script to verify if there are any breaking changes or compatibility issues introduced by the new webpack version:
packages/epk-decryption/package.json (1)
64-64
: Approved: Webpack version update.The update from
5.88.2
to5.94.0
in thewebpack
dependency is aligned with the PR objectives. This should bring in the improvements and bug fixes as noted in the release notes.Run the following script to verify if there are any breaking changes or compatibility issues introduced by the new webpack version:
Verification successful
Recommendation: Test the build process with Webpack 5.94.0.
The webpack configurations appear standard and should not be affected by the update to version 5.94.0. However, it's advisable to run the build process to confirm there are no unexpected issues.
- Ensure that the build scripts execute successfully with the updated webpack version.
- Verify that the output bundles function as expected in your target environments.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Check for any breaking changes or compatibility issues with the new webpack version. # Test: Search for any known issues or breaking changes in the webpack release notes. echo "Check webpack release notes for version 5.94.0 for any breaking changes."Length of output: 154
Script:
#!/bin/bash # Search for webpack configuration files in the repository fd webpack.config # Check for webpack-related scripts in package.json files rg '"webpack":' -A 3 --glob '**/package.json'Length of output: 1236
Script:
#!/bin/bash # Search for common webpack configuration patterns that might be affected by breaking changes # Check for usage of deprecated or changed webpack features in the configuration files rg 'module\.exports' -A 10 --glob '**/webpack.config.js'Length of output: 3050
packages/epk-signature/package.json (1)
63-63
: Approved: Webpack version update.The update from
5.88.2
to5.94.0
in thewebpack
dependency is aligned with the PR objectives. This should bring in the improvements and bug fixes as noted in the release notes.Run the following script to verify if there are any breaking changes or compatibility issues introduced by the new webpack version:
packages/request-client.js/package.json (1)
77-77
: Approve the webpack version update.The update of
webpack
from5.88.2
to5.94.0
in thedevDependencies
is noted. This change aims to leverage the latest bug fixes, security improvements, and features as described in the PR summary.It's crucial to ensure that this update integrates well with the existing project setup. Consider running a full build and test cycle to verify that there are no breaking changes or compatibility issues introduced by this new version. Additionally, reviewing the detailed list of commits and changes between these versions could provide further insights into any potential impacts on the project.
db9ed9a
to
c58a06b
Compare
Bumps [webpack](https://github.com/webpack/webpack) from 5.88.2 to 5.94.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v5.88.2...v5.94.0) --- updated-dependencies: - dependency-name: webpack dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
c58a06b
to
2971b26
Compare
Bumps webpack from 5.88.2 to 5.94.0.
Release notes
Sourced from webpack's releases.
... (truncated)
Commits
eabf85d
chore(release): 5.94.0955e057
security: fix DOM clobbering in auto public path9822387
test: fixcbb86ed
test: fix5ac3d7f
fix: unexpected asi generation with sequence expression2411661
security: fix DOM clobbering in auto public pathb8c03d4
fix: unexpected asi generation with sequence expressionf46a03c
revert: do not use heuristic fallback for "module-import"60f1898
fix: do not use heuristic fallback for "module-import"66306aa
Revert "fix: module-import get fallback from externalsPresets"Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Summary by CodeRabbit
webpack
dependency across multiple modules, enhancing build performance and introducing potential improvements and bug fixes.webpack
version may resolve existing issues related to module bundling and build processes.