chore: add test - create and declare received payment in a single transaction #1443
Conversation
WalkthroughThe recent update introduces a test case in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant RequestNetwork
participant Storage
User->>RequestNetwork: createRequest(requestInfo)
RequestNetwork->>Storage: save request with payment declaration
Storage-->>RequestNetwork: return confirmation
RequestNetwork->>User: return request confirmation
User->>RequestNetwork: check balance
RequestNetwork->>Storage: retrieve updated balance
Storage-->>RequestNetwork: return updated balance
RequestNetwork->>User: display updated balance
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (1)
- packages/request-client.js/test/declarative-payments.test.ts (1 hunks)
Additional context used
Biome
packages/request-client.js/test/declarative-payments.test.ts
[error] 217-217: Forbidden non-null assertion.
Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator
(lint/style/noNonNullAssertion)
| }, | ||
| }); | ||
| const requestData = await request.waitForConfirmation(); | ||
| expect(requestData.balance!.balance).toEqual('10'); |
There was a problem hiding this comment.
Avoid using non-null assertions.
The non-null assertion operator (!) is used on requestData.balance!.balance. It's safer to use optional chaining (?.) to avoid potential runtime errors.
- expect(requestData.balance!.balance).toEqual('10');
+ expect(requestData.balance?.balance).toEqual('10');Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| expect(requestData.balance!.balance).toEqual('10'); | |
| expect(requestData.balance?.balance).toEqual('10'); |
Tools
Biome
[error] 217-217: Forbidden non-null assertion.
Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator
(lint/style/noNonNullAssertion)
Description of the changes
Summary by CodeRabbit
New Features
Tests