You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Received report from hacker at ETHWarsaw that EtheruemFeeProxy transferWithReferenceAndFee() reverts if feeAmount is set to 0. The workaround was to set 1 wei fee. 👍
The EthereumFeeProxy transfers fees using .transfer() which has a hardcoded gas limit of 2300. Smart contract wallets like Safe have logic in their payable fallback() functions that require gas so .transfer() is not compatible with recipients that are smart contract wallets. Use .call() instead.
The text was updated successfully, but these errors were encountered:
MantisClone
changed the title
Deploy and Migrate to new version of EthereumFeeProxy
Deploy and migrate to new version of EthereumFeeProxy
Sep 12, 2023
MantisClone
changed the title
Deploy and migrate to new version of EthereumFeeProxy
Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig
Dec 20, 2023
MantisClone
changed the title
Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig
Deploy and migrate to new version of EthereumFeeProxy - can't send 0 fee?, can't send fees to a multisig
Dec 20, 2023
The EthereumFeeProxy allows you to send 0 fee ✅ see #1218
MantisClone
changed the title
Deploy and migrate to new version of EthereumFeeProxy - can't send 0 fee?, can't send fees to a multisig
Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig
Apr 2, 2024
Problems
Received report from hacker at ETHWarsaw that EtheruemFeeProxytransferWithReferenceAndFee()
reverts if feeAmount is set to 0. The workaround was to set 1 wei fee. 👍The
EthereumFeeProxy
transfers fees using.transfer()
which has a hardcoded gas limit of 2300. Smart contract wallets like Safe have logic in theirpayable fallback()
functions that require gas so.transfer()
is not compatible with recipients that are smart contract wallets. Use.call()
instead.Definition of Done
FixEthereumFeeProxy
to allow 0 feeEthereumFeeProxy
to usecall()
instead oftransfer()
for transferring feesPossible Follow-ups
paymentReference
tobytes8
across all payment proxy contracts #1113Migrated from Asana: https://app.asana.com/0/1203912381456855/1205450558867535/f
The text was updated successfully, but these errors were encountered: