Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig #1149

Open
2 of 6 tasks
MantisClone opened this issue Sep 12, 2023 · 1 comment
Open
2 of 6 tasks

Comments

@MantisClone
Copy link
Member

MantisClone commented Sep 12, 2023

Problems

  1. Received report from hacker at ETHWarsaw that EtheruemFeeProxy transferWithReferenceAndFee() reverts if feeAmount is set to 0. The workaround was to set 1 wei fee. 👍

  2. The EthereumFeeProxy transfers fees using .transfer() which has a hardcoded gas limit of 2300. Smart contract wallets like Safe have logic in their payable fallback() functions that require gas so .transfer() is not compatible with recipients that are smart contract wallets. Use .call() instead.

Definition of Done

  • Investigate if EthereumFeeProxy allows 0 fee - Conclusion: It allows ✅ . See Implement test to show that EtheruemFeeProxy works with 0 fee #1218
  • Fix EthereumFeeProxy to allow 0 fee
  • Fix EthereumFeeProxy to use call() instead of transfer() for transferring fees
  • Deploy new version on all networks where it already exists
  • Update payment-processing and payment-detection packages
  • Communicate new version to all builders.

Possible Follow-ups


Migrated from Asana: https://app.asana.com/0/1203912381456855/1205450558867535/f

@MantisClone MantisClone changed the title Deploy and Migrate to new version of EthereumFeeProxy Deploy and migrate to new version of EthereumFeeProxy Sep 12, 2023
@MantisClone MantisClone changed the title Deploy and migrate to new version of EthereumFeeProxy Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig Dec 20, 2023
@MantisClone MantisClone changed the title Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig Deploy and migrate to new version of EthereumFeeProxy - can't send 0 fee?, can't send fees to a multisig Dec 20, 2023
@MantisClone
Copy link
Member Author

MantisClone commented Apr 2, 2024

The EthereumFeeProxy allows you to send 0 fee ✅ see #1218

@MantisClone MantisClone changed the title Deploy and migrate to new version of EthereumFeeProxy - can't send 0 fee?, can't send fees to a multisig Deploy and migrate to new version of EthereumFeeProxy - can't send fees to a multisig Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🐞🧹 Backlog: Bug, Tech Debt, or Chore
Development

No branches or pull requests

1 participant