Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a Builder, I want Dynamic on-chain SVGs for TransferableReceivable, so I can see parameters of the request when viewing on NFT marketplaces #1098

Open
MantisClone opened this issue Apr 13, 2023 · 2 comments

Comments

@MantisClone
Copy link
Member

MantisClone commented Apr 13, 2023

Should we add dynamic on-chain SVGs to the TransferableReceivable such that key pieces of information like amount, approval state, balance, initial owner are rendered on-chain as part of the NFT image?

Background: Dynamic on-chain SVGs are rendered on-chain using on-chain information and then returned via the tokenURI function.

Example: Uniswap V3 positions.

Pros: The NFT image could display the current ReceivableInfo (tokenAddress, amount, balance, requestId). In the future, we may add the approval state as a public field on the NFT which could be dynamically rendered in an SVG.

Cons: On-chain SVGs drastically increase contract deployment costs


Migrated from Asana: https://app.asana.com/0/1203912381456855/1205300974037107/f

@MantisClone
Copy link
Member Author

A challenge from @benjlevesque :

Why does the SVG generation need to be on-chain?

That's a fair question. For an asset that exists entirely on-chain like Uniswap V3 positions maybe there's a case for on-chain SVGs. But for an on-chain/off-chain asset like TransferableReceivables, we could build an off-chain service that renders the SVGs. Given that there are large portions of a request that already exist off-chain, putting SVG generation off-chain is not that big of a stretch. After this challenge, I lean toward an off-chain solution, if any.

@MantisClone
Copy link
Member Author

Another challenge from @benjlevesque

why do we need an SVG? is it for compatibility with NFT UIs?

It's not compatibility per se. More for professionalism, trust, and quick recognition. The TransferableReceivable NFTs should display an image. even if it's a generic one that all of them share. This could give users more confidence that the token is authentic or legitimate. But it would be even better if the image displayed useful metrics about the request like the approval state, amount, balance, etc.

@MantisClone MantisClone changed the title Dynamic on-chain SVGs for TransferableReceivable? As a Builder, I want Dynamic on-chain SVGs for TransferableReceivable, so I can see parameters of the request when viewing on NFT marketplaces Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🎫 Backlog
Development

No branches or pull requests

1 participant