fix

Author: kevindavee

packages/request-client.js/src/http-data-access-config.ts

@@ -26,7 +26,6 @@ export class HttpDataAccessConfig {
     }: {
       httpConfig?: Partial<ClientTypes.IHttpDataAccessConfig>;
       nodeConnectionConfig?: Partial<NodeConnectionConfig>;
-      persist?: boolean;
     } = {
       httpConfig: {},
       nodeConnectionConfig: {},

packages/request-client.js/src/http-data-access.ts

@@ -35,9 +35,10 @@ export default class HttpDataAccess extends CombinedDataAccess {
     const dataAccessConfig = new HttpDataAccessConfig({ httpConfig, nodeConnectionConfig });
     const transaction = new HttpTransaction(dataAccessConfig);
     const reader = new HttpDataRead(dataAccessConfig);
-    const writer = persist
-      ? new HttpDataWrite(dataAccessConfig, transaction)
-      : new NoPersistDataWrite();
+    const writer =
+      persist === false
+        ? new NoPersistDataWrite()
+        : new HttpDataWrite(dataAccessConfig, transaction);
 
     super(reader, writer);
 

packages/request-client.js/test/api/request-network.test.ts

@@ -16,6 +16,7 @@ const mockDataAccess: DataAccessTypes.IDataAccess = {
   close: jest.fn(),
   persistTransaction: jest.fn(),
   getChannelsByMultipleTopics: jest.fn(),
+  isPersisting: jest.fn().mockReturnValue(true),
 };
 
 describe('api/request-network', () => {

packages/request-client.js/test/in-memory-request.test.ts

@@ -20,8 +20,6 @@ class MyCustomDataAccess extends CombinedDataAccess {
     );
   }
 }
-{
-}
 
 describe('handle in-memory request', () => {
   let requestNetwork: RequestNetwork;