[refactor] Makes enums more readable.

RepmujNetsik · Feb 6, 2015 · 6f59f25 · 6f59f25
1 parent 6e49fc0
commit 6f59f25
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 36 deletions.
diff --git a/command/src/main/java/com/iluwatar/Size.java b/command/src/main/java/com/iluwatar/Size.java
@@ -1,32 +1,22 @@
 package com.iluwatar;
 
 /**
- * 
+ *
  * Enumeration for target size.
  *
  */
 public enum Size {
 
-	SMALL, NORMAL, LARGE;
-
-	@Override
-	public String toString() {
+    SMALL("small"), NORMAL("normal"), LARGE("large"), UNDEFINED("");
+
+    private String title;
 
-		String s = "";
+    Size(String title) {
+        this.title = title;
+    }
 
-		switch (this) {
-		case LARGE:
-			s = "large";
-			break;
-		case NORMAL:
-			s = "normal";
-			break;
-		case SMALL:
-			s = "small";
-			break;
-		default:
-			break;
-		}
-		return s;
+    @Override
+	public String toString() {
+        return title;
 	}
 }
diff --git a/command/src/main/java/com/iluwatar/Visibility.java b/command/src/main/java/com/iluwatar/Visibility.java
@@ -7,24 +7,16 @@
  */
 public enum Visibility {
 
-	VISIBLE, INVISIBLE;
+	VISIBLE("visible"), INVISIBLE("invisible"), UNDEFINED("");
 
-	@Override
-	public String toString() {
-
-		String s = "";
+    private String title;
 
-		switch (this) {
-		case INVISIBLE:
-			s = "invisible";
-			break;
-		case VISIBLE:
-			s = "visible";
-			break;
-		default:
-			break;
+    Visibility(String title) {
+        this.title = title;
+    }
 
-		}
-		return s;
+    @Override
+	public String toString() {
+		return title;
 	}
 }