Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework alignment logic to use API #10

Open
glynnbird opened this issue Aug 18, 2020 · 0 comments
Open

Rework alignment logic to use API #10

glynnbird opened this issue Aug 18, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@glynnbird
Copy link
Member

glynnbird commented Aug 18, 2020

Currently the librosa-powered alignment tech calculates the "offset" for each non-leader part and uses it to trim the videos, which make it to the final rendered output. The offset for each part isn't recorded anywhere and isn't tweakable.

  • ensure that when a librosa-powered alignment operation is undertaken, it's calculated offset is stored using the API (see below)
  • the JS renderer will take the "offset" values for each songpart from the database and save them in the render config JSON
  • the Python renderer will respect the offsets it sees in the JSON file
  • the trimmed bucket will be decomissioned
  • if we choose to tweak an offset in the database (or via a future front-end update) then the results would be reflected in the JSON file and the rendered video.

To record the offset via the API, the following API call is required:

curl -X POST -d'{"choirId":"x", "songId":"y","partId":"z","offset":100}' -H 'Content-type: application/json' "$URL/choir/songpart"

See

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants