feat/AB#106234_EIS-improve-messages-for-file-download #2708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nterceptor for csApi requests error handling feat: add interceptor in all projects feat: add cs api error builder to be able to build error message based on the returned error status from the interceptor feat: change snackbar to be able to handle line breaks in the given string
|
@AntoineRelief , those are example messages. KR, Unai |
| if (request.url.startsWith(this.environment.csApiUrl)) { | ||
| return next.handle(request).pipe( | ||
| catchError((err) => { | ||
| return throwError( |
There was a problem hiding this comment.
indeed, it's due to the responseType
Not sure an interceptor is a good solution, as it's just one request
I'll check that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add new interceptor for csApi requests error handling
feat: add interceptor in all projects
feat: add cs api error builder to be able to build error message based on the returned error status from the interceptor
feat: change snackbar to be able to handle line breaks in the given string
Useful links
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Screenshots
Checklist:
( * == Mandatory )
More explanation
https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145