Skip to content

refactor/AB#82357_create-shared-error-handler-logic-for-the-app #2434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: refactor/AB#82357_update-angular-fix-memory-leak-issues-and-other-fixes
Choose a base branch
from

Conversation

unai-reliefapp
Copy link
Contributor

@unai-reliefapp unai-reliefapp commented Mar 7, 2024

Description

  • feat: add error handler to display default snackbar message from one place for all error coming from our API that are not graphQL related
  • feat: refactor all graphql errors to be treated in the error section of the subscription
  • feat: adapt all grapql subscriptions in order to keep the errors correctly handled as the aforementioned reason

Useful links

Type of change

Please delete options that are not relevant.

  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • Test A
  • Test B

Screenshots

Please include screenshots of this change. If this issue is only back-end related, and does not involve any visual change of the platform, you can skip this part.

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

… add error handler to display default snackbar message from one place for all error coming from our API that are not graphQL related feat: refactor all graphql errors to be treated in the error section of the subscription feat: adapt all grapql subscriptions in order to keep the errors correctly handled as the aforementioned reason
@unai-reliefapp unai-reliefapp self-assigned this Mar 7, 2024
@unai-reliefapp unai-reliefapp added keep Do not delete refactor Refactor of the code in code review Under review labels Mar 7, 2024
…pp feat: update error message handler function in order to format all message types coming from GraphQL requests feat: create error links for GraphQL error handling feat: update related requests with the new subscribe syntax with next and error callbacks to properly handle errors from requests
@unai-reliefapp unai-reliefapp changed the base branch from beta to refactor/AB#82357_update-angular-fix-memory-leak-issues-and-other-fixes March 12, 2024 13:44
…-and-other-fixes' of github.com-relief:ReliefApplications/ems-frontend into refactor/AB#82357_create-shared-error-handler-logic-for-the-app
@unai-reliefapp unai-reliefapp marked this pull request as ready for review March 12, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in code review Under review keep Do not delete refactor Refactor of the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant