Skip to content

AB#84974 - Checkbox does not take into account value from reference data #2365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 2.x.x
Choose a base branch
from

Conversation

guisoares1
Copy link
Contributor

Description

The problem occurs because the value received by reference data (api rest) is different from the value configured in the metadata.

To resolve this, I created a method that corrects the field type when an inconsistency is found between the metadata and its received type.

Useful links

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

  • A reference data was configured that contains this behavior (bool type being received as a string and the metadata configured as the boolean value) and the behavior was observed.

Screenshots

image

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@guisoares1 guisoares1 added the bug Something isn't working label Feb 2, 2024
@guisoares1 guisoares1 self-assigned this Feb 2, 2024
@guisoares1 guisoares1 marked this pull request as ready for review February 2, 2024 17:41
@guisoares1 guisoares1 requested a review from a team February 2, 2024 17:44
@AntoineRelief AntoineRelief requested review from AntoineRelief and removed request for a team February 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant