-
Notifications
You must be signed in to change notification settings - Fork 8
Fix/ab#81892 method for calc in utils parser #2183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: beta
Are you sure you want to change the base?
Conversation
@AntoineRelief is there the option were this values could be placed inside any other element besides span elements? If that the case a little modification should be done in the regex. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works as intended
The only thing is that maybe is some scenario’s it might be that there is nested tags
and will only get the first span
… # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Description
Fixed: Method for calc in utils parser is removing some span in the code.
Useful links
ticket
Type of change
How Has This Been Tested?
It has been tested creating a text widget and putting some {{calc. operations inside the editor using some data to these operations that have style applied to the layout of it, and also testing if others span in the content is not being removed.
Screenshots
Checklist:
( * == Mandatory )