Skip to content

Fix/ab#81892 method for calc in utils parser #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: beta
Choose a base branch
from

Conversation

RenzoPrats
Copy link
Contributor

@RenzoPrats RenzoPrats commented Dec 15, 2023

Description

Fixed: Method for calc in utils parser is removing some span in the code.

Useful links

ticket

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested creating a text widget and putting some {{calc. operations inside the editor using some data to these operations that have style applied to the layout of it, and also testing if others span in the content is not being removed.

Screenshots

Peek 18-12-2023 16-40

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@RenzoPrats RenzoPrats changed the base branch from main to beta December 15, 2023 20:02
@RenzoPrats RenzoPrats self-assigned this Dec 18, 2023
@RenzoPrats RenzoPrats added the bug Something isn't working label Dec 18, 2023
@RenzoPrats RenzoPrats marked this pull request as ready for review December 18, 2023 15:20
@RenzoPrats RenzoPrats marked this pull request as draft December 18, 2023 17:23
@RenzoPrats RenzoPrats marked this pull request as ready for review December 18, 2023 19:41
@unai-reliefapp
Copy link
Contributor

unai-reliefapp commented Dec 19, 2023

@AntoineRelief is there the option were this values could be placed inside any other element besides span elements? If that the case a little modification should be done in the regex.
Otherwise looks good 👍

Copy link
Contributor

@TaiKamilla TaiKamilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as intended
The only thing is that maybe is some scenario’s it might be that there is nested tags
and will only get the first span

… # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants