Skip to content

feat/AB#80878_limit-zoom-of-map-widgets-for-the-given-geographic-context-in-the-page #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feat/AB#80877_add_logic_to_create_edit_load_page_with_geographic_context
Choose a base branch
from

Conversation

unai-reliefapp
Copy link
Contributor

@unai-reliefapp unai-reliefapp commented Dec 13, 2023

Description

feat: update countries data with the coordinates
feat: set all map widgets initial state coordinates as the one selected for the country context if exists

Useful links

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please refer to video below

Screenshots

Compartir.pantalla.-.2023-12-14.08_27_51.1.mp4

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@unai-reliefapp unai-reliefapp self-assigned this Dec 13, 2023
@unai-reliefapp unai-reliefapp added the enhancement New feature or request label Dec 14, 2023
@unai-reliefapp
Copy link
Contributor Author

unai-reliefapp commented Dec 14, 2023

@AntoineRelief I stick to the exact requirements of the ticket, which means that in this PR:

  • Region coordinates are missing(maybe you could provide them later on and I'll add it to this PR)
  • If there is a widget map in the default template and the admin selects a country context, the new page would be created and all the map widgets inside would automatically be updated with the selected country coordinates as their initial state(if no coordinates are set on top by admin, those have priority)
  • If the admin is currently in a geographic context page and it adds a new map widget, the current country coordinates are not automatically applied, they are applied only on dashboard load, which would be always available to the end users when using the page. Should we update the coordinates of new map widget added to a dashboard?

Let me know,
KR, Unai

@unai-reliefapp unai-reliefapp marked this pull request as ready for review December 14, 2023 07:55
@AntoineRelief
Copy link
Collaborator

@unai-reliefapp
you can find approximate coordinates directly on google, at least, to start implementing it

euro -> europa
afro -> africa
etc

@unai-reliefapp
Copy link
Contributor Author

unai-reliefapp commented Dec 15, 2023

@unai-reliefapp you can find approximate coordinates directly on google, at least, to start implementing it

euro -> europa afro -> africa etc

Hi @AntoineRelief , sorry my ignorance 😅 , can you translate me the missing regions please?

AFRO => Africa
AMRO
EMRO
EURO => Europe
SEARO =>
WPRO =>
HQ =>

Thanks

…ext-in-the-page feat: add regions coordinates feat: add automatic center for region context
@unai-reliefapp unai-reliefapp force-pushed the feat/AB#80878_limit-zoom-of-map-widgets-for-the-given-geographic-context-in-the-page branch from ce34b3b to 5819abe Compare December 15, 2023 11:23
@unai-reliefapp
Copy link
Contributor Author

This can be closed @AntoineRelief

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants