Skip to content

feat/AB#80876-add-geographic-context-in-page #2133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: alpha
Choose a base branch
from

Conversation

estelafs
Copy link
Contributor

@estelafs estelafs commented Dec 5, 2023

Description

Updated page model, mutations and queries with the new geographicContext property.
Added toggle to enable/disable geographicContext in the page settings modal when in a dashboard page.
Added to the dashboard page the dropdown with the static values for regions and countries.
Enabled resolveJsonModule to get countries from JSON file.

Useful links

Type of change

  • New feature (non-breaking change which adds functionality)
  • Improvement (refactor or addition to existing functionality)

How Has This Been Tested?

In a dashboard page, enable the geographic context in the page settings modal to see the region and country dropdowns and be able to select

Screenshots

gc.webm

Checklist:

( * == Mandatory )

  • * I have set myself as assignee of the pull request
  • * My code follows the style guidelines of this project
  • * Linting does not generate new warnings
  • * I have performed a self-review of my own code
  • * I have put the ticket for review, adding the oort-frontend team to the list of reviewers
  • * I have commented my code, particularly in hard-to-understand areas
  • * I have put JSDoc comment in all required places
  • * My changes generate no new warnings
  • * I have included screenshots describing my changes if relevant
  • * I have selected labels in the Pull Request, according to the changes with code brings
  • I have made corresponding changes to the documentation ( if required )
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

More explanation

https://www.loom.com/share/05a716d61b9744faaf51fb304c21d1e5?sid=f87cf896-582a-4f76-93ae-8ceed801b145

@estelafs estelafs added the enhancement New feature or request label Dec 5, 2023
@estelafs estelafs requested a review from a team December 5, 2023 20:45
@estelafs estelafs self-assigned this Dec 5, 2023
…tend into feat/AB#80876-add-geographic-context-in-page
…ntry assignation in the html template without the $any cast refactor: move region list to the countries.json file in order to keep all geographic context related in the same place. Renamed countries.json file to geographic-context-data.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants