warnings, better defaults for exp

Author: Refefer

src/graph.rs

@@ -170,9 +170,33 @@ impl Graph {
         }
     }
 
+    pub fn print_graph(node: &ANode) {
+        let mut s = String::new();
+        Graph::print_graph_level(node, 0, &mut s);
+    }
 
+    fn print_graph_level(node: &ANode, depth: usize, buff: &mut String) {
+        buff.clear();
+        for _ in 0..depth {
+            buff.push(' ');
+        }
+        if node.is_leaf() {
+            eprintln!("{}- {}({:?}", buff, node.op_name(), node.value());
+        } else {
+            eprintln!("{}- {}({:?} {{", buff, node.op_name(), node.value());
+            if let Some(children) = node.get_children() {
+                for c in children {
+                    Graph::print_graph_level(c, depth + 1, buff);
+                }
+            }
+            let spaces = &buff[..depth];
+            eprintln!("{}}}", spaces);
+        }
+    }
 }
 
+
+
 pub(crate) struct Run(NodeIdx, Vec<ANode>);
 
 impl Run {
@@ -183,6 +207,8 @@ impl Run {
 }
 
 impl Node for Run {
+    fn op_name(&self) -> &str { "Run" }
+
     fn get_id(&self) -> NodeIdx { self.0.clone() }
 
     fn get_children(&self) -> Option<&[ANode]> { 

src/lib.rs

@@ -30,8 +30,9 @@ impl NodeIdx {
     }
 }
 
-
 pub trait Node {
+    fn op_name(&self) -> &str;
+
     fn get_id(&self) -> NodeIdx;
 
     fn is_leaf(&self) -> bool;
@@ -42,7 +43,6 @@ pub trait Node {
 
     fn requires_grad(&self) -> bool;
 
-    //fn compute_grad(&self, _grad: &[DType], _results: &mut [MPVec]) { }
     fn compute_grad(&self, _grad: &[DType], _results: &mut [&mut [DType]]) { }
 
 }
@@ -76,11 +76,11 @@ impl ANode {
     }
 
     pub fn exp(&self) -> ANode {
-        Exp::new(self.clone(), true)
+        Exp::new(self.clone(), false)
     }
 
-    pub fn exp_exact(&self) -> ANode {
-        Exp::new(self.clone(), false)
+    pub fn exp_approx(&self) -> ANode {
+        Exp::new(self.clone(), true)
     }
 
     pub fn sum(&self) -> ANode {
@@ -91,6 +91,10 @@ impl ANode {
         Slice::new(self.clone(), start, len)
     }
 
+    pub fn name(&self, name: String) -> ANode {
+        Named::new(self.clone(), name)
+    }
+
     fn require_grad(self) -> ANode {
         ANode(Rc::new(RequiresGrad::new(self.0)))
     }