Improve log output further and remove exits

Author: mheguy

git_update_scripts/checkout-pr.sh

@@ -26,6 +26,4 @@ debug=true
 
 source /home/factorio/bin/generic-updater.sh
 
-echo "$folder updated successfully with map: $map"
-
-exit 0
+echo "$folder updated successfully with PR:$1 and map: $map"

git_update_scripts/generic-updater.sh

@@ -18,8 +18,8 @@ if [ -z "$map" ]; then
     exit 1
 fi
 
-git --git-dir=/factorio/scenarios/"$folder"/.git/ --work-tree=/factorio/scenarios/"$folder"/ fetch "$repository"
-git --git-dir=/factorio/scenarios/"$folder"/.git/ --work-tree=/factorio/scenarios/"$folder"/ reset --hard "$repository/$branch"
+git --git-dir=/factorio/scenarios/"$folder"/.git/ --work-tree=/factorio/scenarios/"$folder"/ fetch "$repository" >/dev/null
+git --git-dir=/factorio/scenarios/"$folder"/.git/ --work-tree=/factorio/scenarios/"$folder"/ reset --hard "$repository/$branch" >/dev/null
 
 if [ "$cleanup" = true ]; then
     echo "Deleting all map data."
@@ -43,5 +43,3 @@ else
 fi
 
 touch /factorio/scenarios/"$folder"
-
-exit 0

git_update_scripts/github-webhook.sh

@@ -8,8 +8,10 @@ log_path='/home/factorio/backend_scripts/logs/github_webhook_output.txt'
 {
     echo '------------------------------------------'
     date
+    echo '-'
     "$script_path" develop origin develop default false false
+    echo '-'
     "$script_path" crashsite origin develop crash_site false false
+    echo '-'
     "$script_path" dev-debug origin develop default false true
-    echo '------------------------------------------'
 } >>"$log_path"

git_update_scripts/update-from-args.sh

@@ -28,8 +28,6 @@ if [ -z "$5" ]; then
     exit 1
 elif [ "$5" == 'true' ]; then
     cleanup=true
-elif [ "$5" == 'false' ]; then
-    cleanup=false
 else
     cleanup=$5
 fi
@@ -38,8 +36,6 @@ if [ -z "$6" ]; then
     exit 1
 elif [ "$6" == 'true' ]; then
     debug=true
-elif [ "$6" == 'false' ]; then
-    debug=false
 else
     debug=$6
 fi
@@ -54,5 +50,3 @@ map=$4
 source /home/factorio/bin/generic-updater.sh
 
 echo "$folder updated from $repository/$branch successfully with map: $map"
-
-exit 0

git_update_scripts/update-grilled.sh

@@ -28,5 +28,3 @@ debug=true
 source /home/factorio/bin/generic-updater.sh
 
 echo "$folder updated successfully with map: $map"
-
-exit 0

git_update_scripts/update-plague.sh

@@ -28,5 +28,3 @@ debug=true
 source /home/factorio/bin/generic-updater.sh
 
 echo "$folder updated successfully with map: $map"
-
-exit 0