Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary format #161

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Binary format #161

wants to merge 6 commits into from

Conversation

dumdiedum
Copy link

What/Why/How?

I've added a sampler method for string of format binary which results in an array of numbers. I need this for visualizing samples within node-red nodes which offers an API wrapper functionality for OpenAPI definitions. Maybe this pull request is useful to merge.

Reference

Testing

Screenshots (optional)

Check yourself

  • Code is linted
  • Tested
  • All new/updated code is covered with tests

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

added binary sample method for binary format
added test for binary format
@dumdiedum dumdiedum requested a review from a team as a code owner April 5, 2024 09:59
@AlexVarchuk
Copy link
Contributor

Hi @dumdiedum, thank you a lot for the contribution.
I am not sure about adding binary format to string, because it is not included in documentation.

@adamaltman
Copy link
Member

Wild idea: we should have an extension point for adding your own formats/examples?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants