Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developing-hashes-crdb.md #680

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yanivhershkovich
Copy link
Contributor

The line "Fields in hashes can be initialized as a string using HSET or HMSET or can be used to initialize counter types that are numeric integers using HINCRBY or floats using HINCRBYFLOAT." is outdated.

As per release notes for version 5.4.2 -
"The string data-type in CRDB is now implicitly and dynamically typed, just like open source Redis."

This means that it is no longer significant how the hash is initialized. If the value is numeric, Redis will be able to use it as a counter.
I only highlighted the line and haven't done any changes to it since I'm not sure if it should be removed or changed.
It will need to be consulted with PM/R&D.

The line "Fields in hashes can be initialized as a string using HSET or HMSET or can be used to initialize counter types that are numeric integers using HINCRBY or floats using HINCRBYFLOAT." is outdated.

As per release notes for version 5.4.2 - 
"The string data-type in CRDB is now implicitly and dynamically typed, just like open source Redis."

This means that it is no longer significant how the hash is initialized. If the value is numeric, Redis will be able to use it as a counter.
I only highlighted the line and haven't done any changes to it since I'm not sure if it should be removed or changed.
It will need to be consulted with PM/R&D.
@PazYanoverrr
Copy link
Contributor

@bmansheim - Yaniv is correct. Apparently, this article was not updated appropriately. Same goes for the String page (- see my other PR)

@bmansheim bmansheim mentioned this pull request Feb 12, 2020
@bmansheim bmansheim added bug Documenting software bug, known issue or limitation. in progress Changes are in progress labels Feb 12, 2020
@bmansheim
Copy link
Contributor

Also update content/rs/developing/crdbs/strings.md

@banker banker self-assigned this Feb 2, 2021
@kaitlynmichael
Copy link
Contributor

@banker looks like this PR hasn't been updated in over a year. Can you give an update on the status?

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Documenting software bug, known issue or limitation. in progress Changes are in progress p_Software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants