Skip to content

support quote strings #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
May 30, 2021
Merged

support quote strings #125

merged 25 commits into from
May 30, 2021

Conversation

AvitalFineRedis
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 13, 2021 •
edited
Loading

Codecov Report

Merging #125 (4b20bba) into master (63d3fe3) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #125      +/-   ##
==========================================
- Coverage   85.52%   85.41%   -0.12%     
==========================================
  Files           8        8              
  Lines         525      521       -4     
==========================================
- Hits          449      445       -4     
  Misses         76       76
Impacted Files Coverage Δ
redisgraph/util.py 92.85% <100.00%> (-1.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63d3fe3...4b20bba. Read the comment docs.

@AvitalFineRedis AvitalFineRedis linked an issue May 13, 2021 that may be closed by this pull request
redisgraph-py does not quote strings sent to redis #84
Closed
@AvitalFineRedis AvitalFineRedis marked this pull request as ready for review May 13, 2021 12:27
@AvitalFineRedis AvitalFineRedis requested a review from swilly22 May 13, 2021 12:28
chayim
chayim reviewed May 16, 2021
View reviewed changes
@gkorland gkorland requested a review from chayim May 30, 2021 07:21
chayim
chayim suggested changes May 30, 2021
View reviewed changes
Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorland Can you remove the .idea folder. We shouldn't include IDE settings in our source. The rest is approved.

@lgtm-com
Copy link

lgtm-com bot commented May 30, 2021

This pull request introduces 1 alert when merging c2ee6ec into 63d3fe3 - view on LGTM.com

new alerts:

  • 1 for Unused import

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AvitalFineRedis AvitalFineRedis merged commit 9524b31 into master May 30, 2021
@AvitalFineRedis AvitalFineRedis deleted the support_quote_string branch May 30, 2021 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkorland gkorland gkorland approved these changes

@chayim chayim chayim approved these changes

@swilly22 swilly22 Awaiting requested review from swilly22

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

redisgraph-py does not quote strings sent to redis
3 participants
@AvitalFineRedis @gkorland @chayim