aioredis client with buffer queue #63
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #63 +/- ##
==========================================
+ Coverage 88.54% 89.24% +0.69%
==========================================
Files 9 9
Lines 576 632 +56
==========================================
+ Hits 510 564 +54
- Misses 66 68 +2
Continue to review full report at Codecov.
|
jeffreylovitz
suggested changes
Jun 14, 2021
| @@ -70,7 +70,8 @@ def process_entities(entities): | |||
| @click.option('--max-token-size', '-t', default=500, help='max size of each token in megabytes (default 500, max 512)') | |||
| @click.option('--index', '-i', multiple=True, help='Label:Propery on which to create an index') | |||
| @click.option('--full-text-index', '-f', multiple=True, help='Label:Propery on which to create an full text search index') | |||
| def bulk_insert(graph, host, port, password, user, unix_socket_path, nodes, nodes_with_label, relations, relations_with_type, separator, enforce_schema, skip_invalid_nodes, skip_invalid_edges, escapechar, quote, max_token_count, max_buffer_size, max_token_size, index, full_text_index): | |||
| @click.option('--async-requests', '-A', default=3, help='amount of async requests to be executed in parallel' ) | |||
There was a problem hiding this comment.
number instead of amount
requirements.txt
Outdated
Comment on lines
2
to
3
| click | ||
| anyio |
There was a problem hiding this comment.
Are these actually dependencies?
There was a problem hiding this comment.
will be removed after rebase
| @@ -70,7 +70,8 @@ def process_entities(entities): | |||
| @click.option('--max-token-size', '-t', default=500, help='max size of each token in megabytes (default 500, max 512)') | |||
| @click.option('--index', '-i', multiple=True, help='Label:Propery on which to create an index') | |||
| @click.option('--full-text-index', '-f', multiple=True, help='Label:Propery on which to create an full text search index') | |||
| def bulk_insert(graph, host, port, password, user, unix_socket_path, nodes, nodes_with_label, relations, relations_with_type, separator, enforce_schema, skip_invalid_nodes, skip_invalid_edges, escapechar, quote, max_token_count, max_buffer_size, max_token_size, index, full_text_index): | |||
| @click.option('--async-requests', '-A', default=3, help='amount of async requests to be executed in parallel' ) | |||
| async def bulk_insert(graph, host, port, password, user, unix_socket_path, nodes, nodes_with_label, relations, relations_with_type, separator, enforce_schema, skip_invalid_nodes, skip_invalid_edges, escapechar, quote, max_token_count, max_buffer_size, max_token_size, index, full_text_index, async_requests): | |||
There was a problem hiding this comment.
If I understand correctly, this function is async because otherwise it cannot make async calls?
|
@DvirDukhan please move |
DvirDukhan
force-pushed
the
async_client
branch
5 times, most recently
from
19b5a51 to
740b0f4
Compare
|
done in #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.