RedisAI constructor with custom socket timeout (#45)

Author: sazzad16

README.md

@@ -61,7 +61,15 @@ and
 
 ### Note
 
-Since version `0.10.0`, the chunk size of model (blob) is set to 512mb (536870912 bytes) based on default Redis 
-configuration. This behavior can be changed by `redisai.blob.chunkSize` system property at the beginning of the 
-application. For example, chunk size can be limited to 8mb by setting `-Dredisai.blob.chunkSize=8388608` or 
+**Chunk size:** Since version `0.10.0`, the chunk size of model (blob) is set to 512mb (536870912 bytes) based on 
+default Redis configuration. This behavior can be changed by `redisai.blob.chunkSize` system property at the beginning 
+of the application. For example, chunk size can be limited to 8mb by setting `-Dredisai.blob.chunkSize=8388608` or 
 `System.setProperty(Model.BLOB_CHUNK_SIZE_PROPERTY, "8388608");`. A limit of 0 (zero) would disable chunking.
+
+**Socket timeout:** Operations with large data and/or long processing time may require a higher socket timeout. 
+Following constructor may come in handy for that purpose.
+```
+  HostAndPort hostAndPort = new HostAndPort(host, port);
+  JedisClientConfig clientConfig = DefaultJedisClientConfig.builder().socketTimeoutMillis(largeTimeout).build();
+  new RedisAI(hostAndPort, clientConfig);
+```

src/main/java/com/redislabs/redisai/RedisAI.java

@@ -7,8 +7,11 @@
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import org.apache.commons.pool2.impl.GenericObjectPoolConfig;
 import redis.clients.jedis.BinaryClient;
+import redis.clients.jedis.HostAndPort;
 import redis.clients.jedis.Jedis;
+import redis.clients.jedis.JedisClientConfig;
 import redis.clients.jedis.JedisPool;
 import redis.clients.jedis.JedisPoolConfig;
 import redis.clients.jedis.exceptions.JedisDataException;
@@ -55,6 +58,16 @@ public RedisAI(String host, int port, int timeout, int poolSize, String password
     this(new JedisPool(initPoolConfig(poolSize), host, port, timeout, password));
   }
 
+  /**
+   * Create a new RedisAI client
+   *
+   * @param hostAndPort
+   * @param clientConfig
+   */
+  public RedisAI(HostAndPort hostAndPort, JedisClientConfig clientConfig) {
+    this(new JedisPool(new GenericObjectPoolConfig<>(), hostAndPort, clientConfig));
+  }
+
   /**
    * Create a new RedisAI client
    *

src/test/java/com/redislabs/redisai/RedisAITest.java

@@ -10,7 +10,10 @@
 import org.junit.Assert;
 import org.junit.Before;
 import org.junit.Test;
+import redis.clients.jedis.DefaultJedisClientConfig;
+import redis.clients.jedis.HostAndPort;
 import redis.clients.jedis.Jedis;
+import redis.clients.jedis.JedisClientConfig;
 import redis.clients.jedis.JedisPool;
 
 public class RedisAITest {
@@ -58,6 +61,22 @@ public void testClientPoolSizeConstructorSetTensorFLOAT() {
     }
   }
 
+  @Test
+  public void withoutDefaultConfig() {
+    String host = "localhost";
+    int port = 6379;
+    int largeTimeout = 5000;
+
+    HostAndPort hostAndPort = new HostAndPort(host, port);
+    JedisClientConfig clientConfig =
+        DefaultJedisClientConfig.builder().socketTimeoutMillis(largeTimeout).build();
+
+    try (RedisAI redisAI = new RedisAI(hostAndPort, clientConfig)) {
+      String script = "def bar(a, b): return a + b\n";
+      Assert.assertTrue(redisAI.setScript("script", Device.CPU, script));
+    }
+  }
+
   @Test
   public void testSetTensorNegative() {
     try {