Skip to content

Commit 9f9639a

Browse files
OhadRevahRedHatQE
authored andcommitted
Rename kubevirt_vmi_migration_disk_transfer_rate_bytes metric (#2708)
##### Short description: The metric kubevirt_vmi_migration_disk_transfer_rate_bytes renamed, this PR refactoring the old metric name to the new one. ##### More details: ##### What this PR does / why we need it: ##### Which issue(s) this PR fixes: ##### Special notes for reviewer: ##### jira-ticket: https://issues.redhat.com/browse/CNV-55919 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Updated VM migration observability tests to reference and validate memory transfer rate measurements (replacing the previous disk transfer rate target), ensuring metrics reflect memory transfer behavior. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai -->
1 parent 5993297 commit 9f9639a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tests/observability/metrics/constants.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,9 @@
1717
KUBEVIRT_VMI_STATUS_ADDRESSES = "kubevirt_vmi_status_addresses{{name='{vm_name}'}}"
1818
KUBEVIRT_VMI_MIGRATION_DATA_PROCESSED_BYTES = "kubevirt_vmi_migration_data_processed_bytes{{name='{vm_name}'}}"
1919
KUBEVIRT_VMI_MIGRATION_DATA_REMAINING_BYTES = "kubevirt_vmi_migration_data_remaining_bytes{{name='{vm_name}'}}"
20-
KUBEVIRT_VMI_MIGRATION_DISK_TRANSFER_RATE_BYTES = "kubevirt_vmi_migration_disk_transfer_rate_bytes{{name='{vm_name}'}}"
20+
KUBEVIRT_VMI_MIGRATION_MEMORY_TRANSFER_RATE_BYTES = (
21+
"kubevirt_vmi_migration_memory_transfer_rate_bytes{{name='{vm_name}'}}"
22+
)
2123
KUBEVIRT_VMI_MIGRATION_DIRTY_MEMORY_RATE_BYTES = "kubevirt_vmi_migration_dirty_memory_rate_bytes{{name='{vm_name}'}}"
2224
KUBEVIRT_VM_DISK_ALLOCATED_SIZE_BYTES = "kubevirt_vm_disk_allocated_size_bytes{{name='{vm_name}'}}"
2325
KUBEVIRT_VMI_MIGRATIONS_IN_SCHEDULING_PHASE = "kubevirt_vmi_migrations_in_scheduling_phase"

tests/observability/metrics/test_migration_metrics.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
KUBEVIRT_VMI_MIGRATION_DATA_REMAINING_BYTES,
99
KUBEVIRT_VMI_MIGRATION_DATA_TOTAL_BYTES,
1010
KUBEVIRT_VMI_MIGRATION_DIRTY_MEMORY_RATE_BYTES,
11-
KUBEVIRT_VMI_MIGRATION_DISK_TRANSFER_RATE_BYTES,
11+
KUBEVIRT_VMI_MIGRATION_MEMORY_TRANSFER_RATE_BYTES,
1212
KUBEVIRT_VMI_MIGRATIONS_IN_RUNNING_PHASE,
1313
KUBEVIRT_VMI_MIGRATIONS_IN_SCHEDULING_PHASE,
1414
)
@@ -69,7 +69,7 @@ class TestKubevirtVmiMigrationMetrics:
6969
marks=(pytest.mark.polarion("CNV-11600")),
7070
),
7171
pytest.param(
72-
KUBEVIRT_VMI_MIGRATION_DISK_TRANSFER_RATE_BYTES,
72+
KUBEVIRT_VMI_MIGRATION_MEMORY_TRANSFER_RATE_BYTES,
7373
marks=(pytest.mark.polarion("CNV-11598")),
7474
),
7575
pytest.param(

0 commit comments

Comments
 (0)