Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api version - use class attr and extract api group from api version #1935

Merged
merged 9 commits into from
Jul 28, 2024

Conversation

rnetser
Copy link
Collaborator

@rnetser rnetser commented Jul 25, 2024

Short description:
More details:
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for reviewer:
Bug:

@redhat-qe-bot
Copy link
Contributor

Report bugs in Issues

The following are automatically added:

  • Add reviewers from OWNER file (in the root of the repository) under reviewers section.
  • Set PR size label.
  • New issue is created for the PR. (Closed when PR is merged/closed)
  • Run pre-commit if .pre-commit-config.yaml exists in the repo.

Available user actions:

  • To mark PR as WIP comment /wip to the PR, To remove it from the PR comment /wip cancel to the PR.
  • To block merging of PR comment /hold, To un-block merging of PR comment /hold cancel.
  • To mark PR as verified comment /verified to the PR, to un-verify comment /verified cancel to the PR.
    verified label removed on each new commit push.
  • To cherry pick a merged PR comment /cherry-pick <target branch to cherry-pick to> in the PR.
    • Multiple target branches can be cherry-picked, separated by spaces. (/cherry-pick branch1 branch2)
    • Cherry-pick will be started when PR is merged
  • To build and push container image command /build-and-push-container in the PR (tag will be the PR number).
    • You can add extra args to the Podman build command
      • Example: /build-and-push-container --build-arg OPENSHIFT_PYTHON_WRAPPER_COMMIT=<commit_hash>
  • To add a label by comment use /<label name>, to remove, use /<label name> cancel
  • To assign reviewers based on OWNERS file use /assign-reviewers
  • To check if PR can be merged use /check-can-merge
Supported /retest check runs
  • /retest tox: Retest tox
  • /retest python-module-install: Retest python-module-install
Supported labels
  • hold
  • verified
  • wip
  • lgtm

@redhat-qe-bot redhat-qe-bot requested a review from myakove July 25, 2024 13:27
@redhat-qe-bot redhat-qe-bot requested a review from omrirh July 25, 2024 13:27
@rnetser rnetser changed the title api version - use class attr and extract api group from api version wip: api version - use class attr and extract api group from api version Jul 25, 2024
@rnetser rnetser changed the title wip: api version - use class attr and extract api group from api version api version - use class attr and extract api group from api version Jul 25, 2024
scripts/resource/class_generator.py Outdated Show resolved Hide resolved
@myakove
Copy link
Collaborator

myakove commented Jul 26, 2024

/verified

myakove
myakove previously approved these changes Jul 26, 2024
myakove
myakove previously approved these changes Jul 28, 2024
@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

Copy link

@myakove
Copy link
Collaborator

myakove commented Jul 28, 2024

/verified

@myakove myakove merged commit c8df431 into main Jul 28, 2024
7 checks passed
@myakove myakove deleted the fix-api-version branch July 28, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants