configure function of sfValidators should return void

Author: Ugoku

lib/plugins/sfDoctrinePlugin/lib/validator/sfValidatorDoctrineChoice.class.php

@@ -35,7 +35,7 @@ class sfValidatorDoctrineChoice extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('model');
     $this->addOption('query', null);

lib/plugins/sfDoctrinePlugin/lib/validator/sfValidatorDoctrineUnique.class.php

@@ -52,7 +52,7 @@ public function __construct($options = array(), $messages = array())
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('model');
     $this->addRequiredOption('column');

lib/validator/i18n/sfValidatorI18nChoiceCountry.class.php

@@ -30,7 +30,7 @@ class sfValidatorI18nChoiceCountry extends sfValidatorChoice
    *
    * @see sfValidatorChoice
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

lib/validator/i18n/sfValidatorI18nChoiceLanguage.class.php

@@ -30,7 +30,7 @@ class sfValidatorI18nChoiceLanguage extends sfValidatorChoice
    *
    * @see sfValidatorChoice
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

lib/validator/i18n/sfValidatorI18nChoiceTimezone.class.php

@@ -28,7 +28,7 @@ class sfValidatorI18nChoiceTimezone extends sfValidatorChoice
    *
    * @see sfValidatorChoice
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

lib/validator/sfValidatorAnd.class.php

@@ -69,7 +69,7 @@ public function __construct($validators = null, $options = array(), $messages =
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addOption('halt_on_error', false);
 

lib/validator/sfValidatorBase.class.php

@@ -98,7 +98,7 @@ public function __construct($options = array(), $messages = array())
    *
    * @see __construct()
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
   }
 

lib/validator/sfValidatorBoolean.class.php

@@ -31,7 +31,7 @@ class sfValidatorBoolean extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addOption('true_values', array('true', 't', 'yes', 'y', 'on', '1'));
     $this->addOption('false_values', array('false', 'f', 'no', 'n', 'off', '0'));

lib/validator/sfValidatorCSRFToken.class.php

@@ -21,7 +21,7 @@ class sfValidatorCSRFToken extends sfValidatorBase
   /**
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('token');
 

lib/validator/sfValidatorCallback.class.php

@@ -31,7 +31,7 @@ class sfValidatorCallback extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('callback');
     $this->addOption('arguments', array());

lib/validator/sfValidatorChoice.class.php

@@ -33,7 +33,7 @@ class sfValidatorChoice extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('choices');
     $this->addOption('multiple', false);

lib/validator/sfValidatorDate.class.php

@@ -45,7 +45,7 @@ class sfValidatorDate extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addMessage('bad_format', '"%value%" does not match the date format (%date_format%).');
     $this->addMessage('max', 'The date must be before %max%.');

lib/validator/sfValidatorDateRange.class.php

@@ -33,7 +33,7 @@ class sfValidatorDateRange extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->setMessage('invalid', 'The begin date must be before the end date.');
 

lib/validator/sfValidatorDateTime.class.php

@@ -21,7 +21,7 @@ class sfValidatorDateTime extends sfValidatorDate
   /**
    * @see sfValidatorDate
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

lib/validator/sfValidatorEqual.class.php

@@ -36,7 +36,7 @@ class sfValidatorEqual extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('value');
     $this->addOption('strict', false);

lib/validator/sfValidatorFile.class.php

@@ -50,7 +50,7 @@ class sfValidatorFile extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     if (!ini_get('file_uploads'))
     {

lib/validator/sfValidatorInteger.class.php

@@ -36,7 +36,7 @@ class sfValidatorInteger extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addMessage('max', '"%value%" must be at most %max%.');
     $this->addMessage('min', '"%value%" must be at least %min%.');

lib/validator/sfValidatorIp.class.php

@@ -37,7 +37,7 @@ class sfValidatorIp extends sfValidatorString
   const IP_V6_ONLY_PUBLIC = '6_public';
   const IP_ALL_ONLY_PUBLIC = 'all_public';
 
-  public function configure($options = array(), $messages = array())
+  public function configure(array $options = [], array $messages = []): void
   {
     $this->addOption('version', self::IP_ALL);
 

lib/validator/sfValidatorNumber.class.php

@@ -36,7 +36,7 @@ class sfValidatorNumber extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addMessage('max', '"%value%" must be at most %max%.');
     $this->addMessage('min', '"%value%" must be at least %min%.');

lib/validator/sfValidatorOr.class.php

@@ -60,7 +60,7 @@ public function __construct($validators = null, $options = array(), $messages =
   /**
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->setMessage('invalid', null);
   }

lib/validator/sfValidatorRegex.class.php

@@ -31,7 +31,7 @@ class sfValidatorRegex extends sfValidatorString
    *
    * @see sfValidatorString
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

lib/validator/sfValidatorSchema.class.php

@@ -73,7 +73,7 @@ public function __construct($fields = null, $options = array(), $messages = arra
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addOption('allow_extra_fields', false);
     $this->addOption('filter_extra_fields', true);

lib/validator/sfValidatorString.class.php

@@ -36,7 +36,7 @@ class sfValidatorString extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addMessage('max_length', '"%value%" is too long (%max_length% characters max).');
     $this->addMessage('min_length', '"%value%" is too short (%min_length% characters min).');

lib/validator/sfValidatorTime.class.php

@@ -37,7 +37,7 @@ class sfValidatorTime extends sfValidatorBase
    *
    * @see sfValidatorBase
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addMessage('bad_format', '"%value%" does not match the time format (%time_format%).');
 

lib/validator/sfValidatorUrl.class.php

@@ -41,7 +41,7 @@ class sfValidatorUrl extends sfValidatorRegex
    *
    * @see sfValidatorRegex
    */
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     parent::configure($options, $messages);
 

test/unit/validator/sfValidatorBaseTest.php

@@ -14,7 +14,7 @@
 
 class ValidatorIdentity extends sfValidatorBase
 {
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addOption('foo', 'bar');
     $this->addMessage('foo', 'bar');
@@ -33,7 +33,7 @@ protected function doClean($value): mixed
 
 class ValidatorIdentityWithRequired extends sfValidatorBase
 {
-  protected function configure($options = array(), $messages = array())
+  protected function configure(array $options = [], array $messages = []): void
   {
     $this->addRequiredOption('foo');
   }