Skip to content

Commit 7338be0

Browse files
[tsan] Disable Trace.MemoryAccessSize on Mac
According to comments at https://reviews.llvm.org/D107911, Trace.MemoryAccessSize fails on Mac buildbots. Because this test is newly introduced, and is the only user of the code added in that patch, disable the test on Mac till the problem is resolved. Differential Revision: https://reviews.llvm.org/D108294
1 parent 0166690 commit 7338be0

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,14 @@ TEST(Trace, RestoreAccess) {
7676
run_in_thread(Thread::Func);
7777
}
7878

79-
TEST(Trace, MemoryAccessSize) {
79+
#if SANITIZER_MAC
80+
// Trace.MemoryAccessSize is currently failing on Mac.
81+
// See https://reviews.llvm.org/D107911 for more details.
82+
# define MAYBE_MemoryAccessSize DISABLED_MemoryAccessSize
83+
#else
84+
# define MAYBE_MemoryAccessSize MemoryAccessSize
85+
#endif
86+
TEST(Trace, MAYBE_MemoryAccessSize) {
8087
struct Thread {
8188
struct Params {
8289
uptr access_size, offset, size;

0 commit comments

Comments
 (0)