Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible dependencies - jsonifier v0.9.96 #45

Closed
WangWeiLin-MV opened this issue Aug 1, 2024 · 5 comments · Fixed by microsoft/vcpkg#40868
Closed

Incompatible dependencies - jsonifier v0.9.96 #45

WangWeiLin-MV opened this issue Aug 1, 2024 · 5 comments · Fixed by microsoft/vcpkg#40868

Comments

@WangWeiLin-MV
Copy link

WangWeiLin-MV commented Aug 1, 2024

Compiler: MSVC 19.38
OS: Windows 11
Command: vcpkg install discordcoreapi

Built failed with jsonifier v0.9.96 which introduced many changes, like:

Include\discordcoreapi/Utilities/Etf.hpp(612): error C2039: 'float_t': is not a member of 'jsonifier::concepts'
jsonifier/TypeEntities.hpp(68): note: see declaration of 'jsonifier::concepts'
...
alloc.deallocate(static_cast<object_type*>(objectValue), 1);

Could you please help to take a look? Thanks.

@RealTimeChris
Copy link
Owner

Thanks I will take care of it.

@WangWeiLin-MV
Copy link
Author

WangWeiLin-MV commented Aug 8, 2024

Thanks for your response. Now that vcpkg CI has been fixed, PR testing can be used normally.

@WangWeiLin-MV
Copy link
Author

WangWeiLin-MV commented Aug 9, 2024

Hi, and there is an additional information:

After updating microsoft/vcpkg#39693, when building discordcoreapi, it fails in a few minutes since depends the mismatched jsonifier, but the unusual thing is it hangs on Linux.

If rolling back the jsonifier version, the build will work normally instead of hanging (fail due to a previous known issue).

The phenomenon we have observed so far is that: At the beginning, it occupies all CPU and increase memory usage until all memory is occupied, then system hangs, or system crash due to OOM.

There might be some potential build performance issues about jsonifier.

Reproduce

  • GNU 11 / GNU 12
  • Debian 12
# in vcpkg directory
git pull

# will fail as expected with jsonifier 0.9.95
git revert aac29a32436dc7816fcdfbfc4cbdbeb8fa64315d --no-edit
vcpkg install discordcoreapi

# will hang with jsonifier 0.9.96
git reset --hard HEAD~
vcpkg install discordcoreapi

If there's anything I can help with, please let me know.

@RealTimeChris
Copy link
Owner

I know the issue and it has been fixed in the latest jsonifier dev-branch. I will push it to the main branch.

@RealTimeChris
Copy link
Owner

Alright it should be fixed now..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants